Skip to content

Refactor C++#707

Merged
texodus merged 1 commit intomasterfrom
cpp-refactor
Sep 5, 2019
Merged

Refactor C++#707
texodus merged 1 commit intomasterfrom
cpp-refactor

Conversation

@sc1f
Copy link
Contributor

@sc1f sc1f commented Sep 5, 2019

  • Removes unnecessary string copies in emscripten.cpp
  • Use std::move when possible in constructors for Table, View, and t_view_config
  • Clarify purpose of filter_op in the view config, and refactor base methods to accept "or" as a valid filter op
  • clean up filter parsing in emscripten.cpp

@texodus
Copy link
Member

texodus commented Sep 5, 2019

Looks good, thanks for the PR!

@texodus texodus merged commit aa32e7c into master Sep 5, 2019
@texodus texodus deleted the cpp-refactor branch September 5, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants