Enable update with __INDEX__ on explicit index column#733
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 59 59
Lines 2141 2141
=======================================
Hits 1976 1976
Misses 165 165Continue to review full report at Codecov.
|
Member
|
Thanks for the PR! Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
abort()we previously added for updates using implicit index, thus updates using__INDEX__(which always shadows the primary key) now work on indexed tables.