Rewrite Perspective Jupyterlab and Phosphor API#756
Merged
Conversation
timkpaine
requested changes
Oct 7, 2019
Member
timkpaine
left a comment
timkpaine
left a comment
There was a problem hiding this comment.
Need to remove start and allow widget to be given data directly
timkpaine
reviewed
Oct 8, 2019
timkpaine
reviewed
Oct 8, 2019
timkpaine
reviewed
Oct 8, 2019
… load() calls on the same widget
…imestring in Python
Member
|
Thanks for the PR! Very cool, also thanks @timkpaine for the extensive review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites the Jupyterlab and Phosphor API for Perspective.
Using the new python API, perspective-jupyterlab now uses
TableandPerspectiveManagerto handle data loads, view creation, etc. The viewer in the widget has access to a proxy table, and all operations in the viewer are proxied to the underlying Table instance in the kernel. Thus, the new widget is bound to the semantics of Table, and accepts any of the data formats accepted byperspective.Table.As part of this PR, the jupyterlab and phosphor widgets have been rewritten. Specifically, the Phosphor widget is made inert, i.e.
loadmust be called on the widget in order to provide the viewer with data. The Jupyterlab widget extends the phosphor widget and implements a client that interacts withPerspectiveManagerin the kernel.Example notebooks have been added to illustrate semantics and usage of the new widgets in JupyterLab.