Conversation
…tr, raise hard error for non-string column names
timkpaine
previously requested changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the inference of dates and datetimes for pandas DataFrames, specifically for
DatetimeIndexof various frequencies. Instead of inferring the data type based on thedatetime64unit, we use the index's datetime frequency to decide whether to type the column as a date or a datetime.Other fixes:
fillnafrom our dataframe processing flowmasked_invalidand non top-level numpy/pandas APIutil.make_dataframeandutil.make_seriesas test utilities