Merged
Conversation
texodus
force-pushed
the
async-resize
branch
3 times, most recently
from
1a58e3c to
6e5ccd2
Compare
…ts, removed old tests
texodus
force-pushed
the
async-resize
branch
from
6e5ccd2 to
746f126
Compare
texodus
force-pushed
the
async-resize
branch
from
746f126 to
64c6c01
Compare
zemeolotu
reviewed
Dec 11, 2019
zemeolotu
approved these changes
Dec 11, 2019
texodus
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
notifyResize()andtoggleConfig()methods async, such that redraws for size changes canawaitthe finished render. The PR also resolves several race conditions in this feature, and makes the test suite better able to track these sorts of issues by adding:--interactivewill run Puppeteer in headed mode and pause when an error is detected.--saturateworks across tests now for running test cases in a loop until they fail.