Remove @finos/perspective-phosphor and fix #825 regression.#919
Merged
Remove @finos/perspective-phosphor and fix #825 regression.#919
@finos/perspective-phosphor and fix #825 regression.#919Conversation
texodus
force-pushed
the
remove-perspective-phosphor
branch
from
86d24ef to
a0c67e1
Compare
sc1f
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #825 "Hypergrid doesn't resize when PerspectiveWidget is resized" was unintentionally reverted. This is due to the use of a
MutationObserveron thestyleattribute of the.p-Widgetcontainer - while this may be appropriate for Jupyterlab, we cannot rely on this expense catch-all in performance critical environments like@finos/perspective-workspace.However,
@finos/perspective-workspaceno longer shares@finos/perspective-phosphor. Ergo, this path also removes this module and merges it with@finos/perspective-jupyterlab.Additionally, a test suite for
@finos/perspective-jupyterlabhas been added, and tests for resizing (as in #825) have been written to ensure this never happens again.