Conversation
texodus
added
internal
texodus
force-pushed
the
cov-js
branch
2 times, most recently
from
d622161 to
abac3aa
Compare
…ode.js` webpack.
zemeolotu
reviewed
Feb 13, 2020
zemeolotu
suggested changes
Feb 13, 2020
Contributor
zemeolotu
left a comment
zemeolotu
left a comment
There was a problem hiding this comment.
perspective-workspace/src/workspace/workspace.js breaks global filters
zemeolotu
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to poor interplay between Webpack and Puppeteer, this will unfortunately only work for
@finos/perspectivefor now, but better this than nothing! In order to get meaningful module name reporting here, I've also gone ahead and removed theperspective.node.jswebpack step entirely, andnodepart of this module now references the babel output directly.Example here
Also removes the FINOS/Operating badge from
README.md, as it links to an access-restricted (dead?) Confluence page.