Conversation
…ce` to perspective-datagrid
texodus
approved these changes
Mar 27, 2020
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I have added a few commits to this. First was to change the method for detecting table to look for a function-like view, instead of using __proto__, as it is deprecated in all browsers and should not be used..
The new example is great! In an effort to trim down the ever growing zoo of similar examples, I've also added a commit to this PR that removes the non-workspace "remote" example as its now redundant.
Member
|
fixes #988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains multiple
perspective-workspacebug fixes, includingtablesnot working withperspective-workspace