Skip to content

Commit 30dc008

Browse files
Dependabot/npm and yarn/tracdap api/packages/web/tmp 0.2.5 (#628)
* Azure arrow native storage (#626) * Add arrow native provide for Azure storage in the runtime * Add a test case for arrow native stoerage provider for Azure blob in runtime integration tests * Change default auth params for fsspec vs arrow * Change default auth params for fsspec vs arrow * Add support for SAS token and account key in Azure storage * Add support for SAS token and account key in Azure Python integration tests * Use SAS token credentials for Arrow Azure FS in CI * Update storage semantics for arrow native on Azure * Use federated auth for CI on GCP (workaround using access token is no longer needed) * Remove outdated comment for Python on GCP * Always run both sets of GCP integration tests in Python * Always run both sets of Azure integration tests in Python * Note on OIDC workload identity SAS token workaround * Remove testing content from AZ storage setup script in CI * Do not run storage test suite for Azure with Arrow native impl in CI (OIDC requires fixes upstream) * Update run config template for PY integration tests * Fix comment in Azure storage plugin * Bump tmp from 0.2.1 to 0.2.5 in /tracdap-api/packages/web Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.5. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.1...v0.2.5) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Do not run storage CI for dependabot (this is the same as PRs from forks) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 parent e896c03 commit 30dc008

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

.github/workflows/integration.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,8 @@ jobs:
334334
target: ${{ matrix.storage.TARGET }}
335335
protocol: ${{ matrix.storage.PROTOCOL }}
336336
matrix: ${{ toJson( matrix.storage ) }}
337-
enabled: ${{ vars[ matrix.storage.ENABLE_IF ] != '' }}
337+
# Dependabot branches are in the main repo but it does not have permissions for CI storage
338+
enabled: ${{ vars[ matrix.storage.ENABLE_IF ] != '' && github.actor != 'dependabot[bot]' }}
338339
has_java: ${{ matrix.storage.JAVA_TESTS != '' }}
339340
has_python: ${{ matrix.storage.PYTHON_TESTS != '' }}
340341

tracdap-api/packages/web/package-lock.json

Lines changed: 8 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tracdap-runtime/python/src/tracdap/rt/_plugins/storage_azure.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,7 @@ def setup_client_args(self, runtime_fs: str) -> tp.Dict[str, tp.Any]:
156156

157157
def setup_credentials(self, runtime_fs: str):
158158

159-
# Only default (Google ADC) mechanism is supported
160-
# Arrow GCP FS does also support access tokens, but ADC is probably all we ever need
159+
# Default mechanism includes ENV, CLI, workload identity and managed identity
161160

162161
mechanism = _helpers.get_plugin_property(self._properties, self.CREDENTIALS_PROPERTY)
163162

0 commit comments

Comments
 (0)