Skip to content

Commit 017eb15

Browse files
authored
Permanently fix sign out crashes (#1252)
2 parents 88c52da + 8faf550 commit 017eb15

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

auth/src/main/java/com/firebase/ui/auth/data/remote/FacebookSignInHandler.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.facebook.FacebookCallback;
1313
import com.facebook.FacebookException;
1414
import com.facebook.FacebookRequestError;
15-
import com.facebook.FacebookSdk;
1615
import com.facebook.GraphRequest;
1716
import com.facebook.GraphResponse;
1817
import com.facebook.WebDialog;
@@ -43,13 +42,11 @@ public class FacebookSignInHandler extends ProviderSignInBase<AuthUI.IdpConfig>
4342
static {
4443
boolean available;
4544
try {
46-
//noinspection unused to possibly throw
47-
Class c = FacebookSdk.class;
45+
Class.forName("com.facebook.login.LoginManager");
4846
available = true;
49-
} catch (NoClassDefFoundError e) {
47+
} catch (ClassNotFoundException e) {
5048
available = false;
5149
}
52-
//noinspection ConstantConditions IntelliJ is wrong
5350
IS_AVAILABLE = available;
5451
}
5552

auth/src/main/java/com/firebase/ui/auth/data/remote/TwitterSignInHandler.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,13 @@ public class TwitterSignInHandler extends ProviderSignInBase<Void> {
3535
static {
3636
boolean available;
3737
try {
38-
//noinspection unused to possibly throw
39-
Class c = TwitterCore.class;
38+
Class.forName("com.twitter.sdk.android.core.identity.TwitterAuthClient");
4039
available = true;
41-
} catch (NoClassDefFoundError e) {
40+
} catch (ClassNotFoundException e) {
4241
available = false;
4342
}
44-
//noinspection ConstantConditions IntelliJ is wrong
4543
IS_AVAILABLE = available;
4644

47-
//noinspection ConstantConditions IntelliJ is still wrong
4845
if (IS_AVAILABLE) {
4946
Context context = AuthUI.getApplicationContext();
5047
Twitter.initialize(new TwitterConfig.Builder(context)

0 commit comments

Comments
 (0)