Skip to content

Commit 0f894a9

Browse files
authored
Merge pull request #371 from amandle/log_login_errors
Better logging when IDP login fails.
2 parents 4a40143 + 6483745 commit 0f894a9

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ public void onCancel() {
178178

179179
@Override
180180
public void onError(FacebookException error) {
181+
Log.e(TAG, "Error logging in with Facebook. " + error.getMessage());
181182
Bundle extra = new Bundle();
182183
extra.putString(ERROR, "error");
183184
extra.putString(ERROR_MSG, error.getMessage());

auth/src/main/java/com/firebase/ui/auth/provider/GoogleProvider.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
126126
if (result.isSuccess()) {
127127
mIDPCallback.onSuccess(createIDPResponse(result.getSignInAccount()));
128128
} else {
129-
onError(result.getStatus().getStatusMessage());
129+
onError(result);
130130
}
131131
} else {
132132
onError("No result found in intent");
@@ -140,7 +140,13 @@ public void startLogin(Activity activity) {
140140
activity.startActivityForResult(signInIntent, RC_SIGN_IN);
141141
}
142142

143+
private void onError(GoogleSignInResult result) {
144+
String errorMessage = result.getStatus().getStatusMessage();
145+
onError(String.valueOf(result.getStatus().getStatusCode()) + " " + errorMessage);
146+
}
147+
143148
private void onError(String errorMessage) {
149+
Log.e(TAG, "Error logging in with Google. " + errorMessage);
144150
Bundle extra = new Bundle();
145151
extra.putString(ERROR_KEY, errorMessage);
146152
mIDPCallback.onFailure(extra);

auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import android.content.Intent;
66
import android.os.Bundle;
77

8+
import android.util.Log;
89
import com.firebase.ui.auth.IdpResponse;
910
import com.firebase.ui.auth.R;
1011
import com.google.firebase.auth.AuthCredential;
@@ -20,6 +21,8 @@
2021
import io.fabric.sdk.android.Fabric;
2122

2223
public class TwitterProvider extends Callback<TwitterSession> implements IdpProvider {
24+
private static final String TAG = "TwitterProvider";
25+
2326
private IdpCallback mCallbackObject;
2427
private TwitterAuthClient mTwitterAuthClient;
2528

@@ -63,6 +66,7 @@ public void success(Result<TwitterSession> result) {
6366

6467
@Override
6568
public void failure(TwitterException exception) {
69+
Log.e(TAG, "Failure logging in to Twitter. " + exception.getMessage());
6670
mCallbackObject.onFailure(new Bundle());
6771
}
6872

0 commit comments

Comments
 (0)