Skip to content

Commit 1a6f7bb

Browse files
SUPERCILEXsamtstern
authored andcommitted
Add info regarding tests, lint, and checkstyle (#509)
1 parent dd6dd6a commit 1a6f7bb

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,10 @@ Feature parity (where it makes sense) is a strict requirement for feature develo
3030
### Code reviews
3131

3232
All submissions, including submissions by project members, require review. We
33-
use Github pull requests for this purpose. We adhere to the
33+
use GitHub pull requests for this purpose. We adhere to the
3434
[Google Java style guide](https://google.github.io/styleguide/javaguide.html).
35+
In addition, style and lint checks are run on each Travis build to ensure quality. To run the full
36+
suite of tests, checks, lint, etc, use `./gradlew check` (this will ensure the Travis build passes).
3537

3638
### The small print
3739

PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
22

33
* Read [the contribution guidelines](CONTRIBUTING.md).
4+
* Run `./gradlew check` to ensure the Travis build passes.
45
* If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
56
* If this is a new feature please co-ordinate with someone on [FirebaseUI-iOS](https://github.com/firebase/firebaseui-ios) to make sure that we can implement this on both platforms and maintain feature parity.

0 commit comments

Comments
 (0)