Fixes lint errors and auth method picker landscape issues.

Author: lsirac

auth/src/main/AndroidManifest.xml

@@ -39,13 +39,13 @@
             android:name=".ui.email.EmailActivity"
             android:label="@string/fui_sign_in_default"
             android:exported="false"
-            android:windowSoftInputMode="adjustResize" />
+            android:windowSoftInputMode="adjustPan" />
 
         <activity
             android:name=".ui.phone.PhoneActivity"
             android:label="@string/fui_sign_in_with_phone_number"
             android:exported="false"
-            android:windowSoftInputMode="adjustResize|stateAlwaysVisible" />
+            android:windowSoftInputMode="adjustPan|stateAlwaysVisible" />
 
         <activity
             android:name=".ui.idp.WelcomeBackIdpPrompt"

auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml

@@ -37,10 +37,16 @@
     <TextView
         android:id="@+id/main_tos_and_pp"
         style="@style/FirebaseUI.Text.BodyText"
-        android:layout_width="match_parent"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
+        android:layout_marginLeft="32dp"
+        android:layout_marginRight="32dp"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:layout_marginBottom="16dp"
+        android:gravity="center"
         android:textColor="?android:attr/textColorTertiary"
-        app:layout_constraintTop_toBottomOf="parent" />
-
+        android:textIsSelectable="true"
+        app:layout_constraintLeft_toLeftOf="parent"
+        app:layout_constraintRight_toLeftOf="@id/container"
+        app:layout_constraintBottom_toBottomOf="parent" />
 </android.support.constraint.ConstraintLayout>

auth/src/main/res/layout/fui_auth_method_picker_layout.xml

@@ -13,6 +13,8 @@
     <ImageView
         android:id="@+id/logo"
         style="@style/FirebaseUI.AuthMethodPicker.Logo"
+        android:layout_marginTop="16dp"
+        android:layout_marginBottom="16dp"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent"
@@ -26,24 +28,25 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintBottom_toBottomOf="parent"
+        app:layout_constraintBottom_toTopOf="@id/main_tos_and_pp"
         app:layout_constraintVertical_bias="0.7">
 
         <LinearLayout
             android:id="@+id/btn_holder"
-            style="@style/FirebaseUI.AuthMethodPicker.ButtonHolder"/>
+            style="@style/FirebaseUI.AuthMethodPicker.ButtonHolder" />
+
     </ScrollView>
+
     <TextView
         android:id="@+id/main_tos_and_pp"
         style="@style/FirebaseUI.Text.BodyText"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
-        android:textColor="?android:textColorTertiary"
-        android:textIsSelectable="false"
+        android:layout_marginBottom="16dp"
         android:gravity="center"
-        app:layout_constraintTop_toBottomOf="@id/container"/>
-</android.support.constraint.ConstraintLayout>
-
-
+        android:textColor="?android:textColorTertiary"
+        android:textIsSelectable="true"
+        app:layout_constraintBottom_toBottomOf="parent" />
 
+</android.support.constraint.ConstraintLayout>

auth/src/main/res/layout/fui_check_email_layout.xml

@@ -56,9 +56,11 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:paddingLeft="16dp"
         android:paddingRight="16dp"
         android:paddingBottom="16dp"
         android:gravity="end"
+        android:textIsSelectable="true"
         app:layout_constraintBottom_toBottomOf="parent" />
 
 </android.support.constraint.ConstraintLayout>

auth/src/main/res/layout/fui_confirmation_code_layout.xml

@@ -95,7 +95,6 @@
                 tools:text="Resend code" />
 
             <android.support.constraint.Barrier
-                android:id="@+id/tos_barrier"
                 android:layout_width="0dp"
                 android:layout_height="0dp"
                 app:barrierDirection="bottom"
@@ -110,8 +109,10 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:paddingLeft="16dp"
         android:paddingRight="16dp"
         android:paddingBottom="16dp"
         android:gravity="end"
+        android:textIsSelectable="true"
         app:layout_constraintBottom_toBottomOf="parent" />
 </android.support.constraint.ConstraintLayout>

auth/src/main/res/layout/fui_phone_layout.xml

@@ -62,9 +62,11 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:paddingLeft="16dp"
         android:paddingRight="16dp"
         android:paddingBottom="16dp"
         android:gravity="end"
+        android:textIsSelectable="true"
         app:layout_constraintBottom_toBottomOf="parent" />
 </android.support.constraint.ConstraintLayout>
 

auth/src/main/res/layout/fui_register_email_layout.xml

@@ -68,7 +68,6 @@
                 style="@style/FirebaseUI.Button"
                 android:text="@string/fui_button_text_save"
                 tools:ignore="RtlHardcoded" />
-
         </LinearLayout>
 
     </ScrollView>
@@ -78,9 +77,12 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/fui_field_padding_vert"
+        android:paddingLeft="16dp"
         android:paddingRight="16dp"
         android:paddingBottom="16dp"
         android:gravity="end"
+        android:textIsSelectable="true"
         app:layout_constraintBottom_toBottomOf="parent" />
+
 </android.support.constraint.ConstraintLayout>