Skip to content

Commit 9fb5779

Browse files
authored
Update CONTRIBUTING.md
Adding additional feature parity guidelines
1 parent f186104 commit 9fb5779

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,26 @@ need to be sure of various other things—for instance that you'll tell us if yo
1212
know that your code infringes on other people's patents. You don't have to sign
1313
the CLA until after you've submitted your code for review and a member has
1414
approved it, but you must do it before we can put your code into our codebase.
15+
16+
### Adding new features
17+
1518
Before you start working on a larger contribution, you should get in touch with
1619
us first through the issue tracker with your idea so that we can help out and
1720
possibly guide you. Coordinating up front makes it much easier to avoid
1821
frustration later on.
1922

23+
If this has been discussed in an issue, make sure to mention the issue number.
24+
If not, go file an issue about this to make sure this is a desirable change.
25+
26+
If this is a new feature please co-ordinate with someone on [FirebaseUI-iOS](https://github.com/firebase/FirebaseUI-iOS)
27+
to make sure that we can implement this on both platforms and maintain feature parity.
28+
Feature parity (where it makes sense) is a strict requirement for feature development in FirebaseUI.
29+
2030
### Code reviews
2131

2232
All submissions, including submissions by project members, require review. We
23-
use GitHub pull requests for this purpose.
33+
use Github pull requests for this purpose. We adhere to the
34+
[Google Java style guide](https://google.github.io/styleguide/javaguide.html).
2435

2536
### The small print
2637

0 commit comments

Comments
 (0)