File tree 1 file changed +12
-1
lines changed
1 file changed +12
-1
lines changed Original file line number Diff line number Diff line change @@ -12,15 +12,26 @@ need to be sure of various other things—for instance that you'll tell us if yo
12
12
know that your code infringes on other people's patents. You don't have to sign
13
13
the CLA until after you've submitted your code for review and a member has
14
14
approved it, but you must do it before we can put your code into our codebase.
15
+
16
+ ### Adding new features
17
+
15
18
Before you start working on a larger contribution, you should get in touch with
16
19
us first through the issue tracker with your idea so that we can help out and
17
20
possibly guide you. Coordinating up front makes it much easier to avoid
18
21
frustration later on.
19
22
23
+ If this has been discussed in an issue, make sure to mention the issue number.
24
+ If not, go file an issue about this to make sure this is a desirable change.
25
+
26
+ If this is a new feature please co-ordinate with someone on [ FirebaseUI-iOS] ( https://github.com/firebase/FirebaseUI-iOS )
27
+ to make sure that we can implement this on both platforms and maintain feature parity.
28
+ Feature parity (where it makes sense) is a strict requirement for feature development in FirebaseUI.
29
+
20
30
### Code reviews
21
31
22
32
All submissions, including submissions by project members, require review. We
23
- use GitHub pull requests for this purpose.
33
+ use Github pull requests for this purpose. We adhere to the
34
+ [ Google Java style guide] ( https://google.github.io/styleguide/javaguide.html ) .
24
35
25
36
### The small print
26
37
You can’t perform that action at this time.
0 commit comments