Skip to content

Commit c387047

Browse files
SUPERCILEXsamtstern
authored andcommitted
Fix GitHub provider NPE when no perms are supplied (#1405)
1 parent 71fa34a commit c387047

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/data/remote/GitHubSignInHandler.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,15 @@ private static IdpResponse createIdpResponse(
8080

8181
@Override
8282
protected void onCreate() {
83-
List<String> permissions = new ArrayList<>(getArguments().getParams()
84-
.getStringArrayList(ExtraConstants.GITHUB_PERMISSIONS));
83+
List<String> permissions = getArguments().getParams()
84+
.getStringArrayList(ExtraConstants.GITHUB_PERMISSIONS);
85+
86+
if (permissions == null) {
87+
permissions = new ArrayList<>();
88+
} else {
89+
permissions = new ArrayList<>(permissions);
90+
}
91+
8592
if (!permissions.contains(EMAIL_PERMISSION)) {
8693
permissions.add(EMAIL_PERMISSION);
8794
}

0 commit comments

Comments
 (0)