Show loading dialog while providers are fetching extra information (#1204)

Author: SUPERCILEX

auth/src/main/java/com/firebase/ui/auth/data/remote/FacebookSignInHandler.java

@@ -112,6 +112,8 @@ protected void onCleared() {
     private class Callback implements FacebookCallback<LoginResult> {
         @Override
         public void onSuccess(LoginResult result) {
+            setResult(Resource.<IdpResponse>forLoading());
+
             GraphRequest request = GraphRequest.newMeRequest(result.getAccessToken(),
                     new ProfileRequest(result));
 

auth/src/main/java/com/firebase/ui/auth/data/remote/TwitterSignInHandler.java

@@ -88,6 +88,7 @@ public void onActivityResult(int requestCode, int resultCode, @Nullable Intent d
     private class TwitterSessionResult extends Callback<TwitterSession> {
         @Override
         public void success(final Result<TwitterSession> sessionResult) {
+            setResult(Resource.<IdpResponse>forLoading());
             TwitterCore.getInstance()
                     .getApiClient()
                     .getAccountService()

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

@@ -170,7 +170,16 @@ private void populateIdpList(List<IdpConfig> providerConfigs,
             provider.getOperation().observe(this, new Observer<Resource<IdpResponse>>() {
                 @Override
                 public void onChanged(Resource<IdpResponse> resource) {
-                    handler.startSignIn(IdpResponse.from(resource));
+                    if (resource.getState() == State.LOADING) {
+                        getDialogHolder().showLoadingDialog(R.string.fui_progress_dialog_loading);
+                        return;
+                    }
+                    getDialogHolder().dismissDialog();
+
+                    if (resource.getState() == State.SUCCESS
+                            || resource.getState() == State.FAILURE) {
+                        handler.startSignIn(IdpResponse.from(resource));
+                    }
                 }
             });
 

auth/src/main/java/com/firebase/ui/auth/ui/idp/SingleSignInActivity.java

@@ -81,7 +81,16 @@ protected void onCreate(Bundle savedInstanceState) {
         mProvider.getOperation().observe(this, new Observer<Resource<IdpResponse>>() {
             @Override
             public void onChanged(Resource<IdpResponse> resource) {
-                mHandler.startSignIn(IdpResponse.from(resource));
+                if (resource.getState() == State.LOADING) {
+                    getDialogHolder().showLoadingDialog(R.string.fui_progress_dialog_loading);
+                    return;
+                }
+                getDialogHolder().dismissDialog();
+
+                if (resource.getState() == State.SUCCESS
+                        || resource.getState() == State.FAILURE) {
+                    mHandler.startSignIn(IdpResponse.from(resource));
+                }
             }
         });
 

auth/src/main/java/com/firebase/ui/auth/ui/idp/WelcomeBackIdpPrompt.java

@@ -128,7 +128,16 @@ protected void onCreate(Bundle savedInstanceState) {
         mProvider.getOperation().observe(this, new Observer<Resource<IdpResponse>>() {
             @Override
             public void onChanged(Resource<IdpResponse> resource) {
-                handler.startSignIn(IdpResponse.from(resource));
+                if (resource.getState() == State.LOADING) {
+                    getDialogHolder().showLoadingDialog(R.string.fui_progress_dialog_loading);
+                    return;
+                }
+                getDialogHolder().dismissDialog();
+
+                if (resource.getState() == State.SUCCESS
+                        || resource.getState() == State.FAILURE) {
+                    handler.startSignIn(IdpResponse.from(resource));
+                }
             }
         });