Skip to content

No "data rates may apply" message when using only Phone Auth method #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nabax opened this issue Jan 1, 2019 · 4 comments
Closed

No "data rates may apply" message when using only Phone Auth method #1559

nabax opened this issue Jan 1, 2019 · 4 comments

Comments

@nabax
Copy link

nabax commented Jan 1, 2019

Using FirebaseUI Auth to manage authentication only with phone method.
If I set only "PhoneBuilder" as AvailableProvider, the "phone number verification" screen does not show the text "By tapping "Verify Phone number", an SMS may be sent. Message & data rates may apply".
See here:
2019-01-01_171702

If I add any other provider (so that at least 2 methods are available and thus the Authentication Method Picker is presented at first), clicking on "phone authentication" takes me to the "phone number verification" page where the text correctly appears.
See here:
2019-01-01_171821

Here's my list of dependencies (already had to roll back to firebase-ui-auth 4.1.0 to avoid the alignement issue described in #1555):

implementation 'com.android.support:appcompat-v7:28.0.0'
implementation 'com.android.support.constraint:constraint-layout:1.1.3'
implementation 'com.android.support:design:28.0.0'
implementation 'com.google.firebase:firebase-core:16.0.6'
implementation 'com.google.firebase:firebase-messaging:17.3.4'
implementation 'com.firebaseui:firebase-ui-auth:4.1.0' 

Do you know how to get the message to appears also when only Phone method is used?
Thank you

@samtstern samtstern added this to the 4.3.1 milestone Jan 2, 2019
@samtstern
Copy link
Contributor

@nabax can you show your code where you are building up the AuthUI.SignInIntentBuilder? Specifically the part where you set the ToS and Privacy policy? I don't see this behavior in my sample app.

@samtstern
Copy link
Contributor

Ah OK I see the conditions where this happens now:

  • No terms or privacy policy URL is set
  • The only available provider is the phone number

In this case, there is no text shown.

@nabax
Copy link
Author

nabax commented Jan 3, 2019

Yes, that's correct: no ToS/PP is set.
Thank you.

@samtstern
Copy link
Contributor

This has been fixed and released in version 4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants