Skip to content

FirestorePagingAdapter does not log errors by default #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanisloandras opened this issue Jul 7, 2019 · 2 comments
Closed

FirestorePagingAdapter does not log errors by default #1652

sanisloandras opened this issue Jul 7, 2019 · 2 comments

Comments

@sanisloandras
Copy link

Hello!

Recently I discovered that FirestorePagingAdapter does not log errors by default, while FirestoreRecylcerAdapter does.
I think it should save developers some time. I lost some time while debugging why my FirestorePagingAdapter didn't not display any data. I simply forgot to create an index, but I didn't get the warning log about that, because FirestorePagingAdapter's onError method body is empty.

FirestoreRecyclerAdapter:
@Override public void onError(@NonNull FirebaseFirestoreException e) { Log.w(TAG, "onError", e); }

FirestorePagingAdapter:
protected void onError(@NonNull Exception e) { // For overriding }

@samtstern samtstern added this to the 5.0.1 milestone Jul 8, 2019
@samtstern
Copy link
Contributor

@sanisloandras I think this is a great idea, would you like to submit a PR with this change?

@samtstern
Copy link
Contributor

This has been released in FirebaseUI 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants