-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Recent removal of Play Services dependency from Firebase-auth #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@RPCarter53 please don't file empty issues, there's no way I can know what you're asking. If you're wondering if we can remove the Play services dependency from FirebaseUI: maybe in the long term, but not immediately. The reason is that Google Sign In still requires Play services and untangling that dependency is going to be a pretty big project! But I do hope we can get there eventually. |
Thanks for the prompt response. The issue we have with Play Services is always the Amazon Fire tablets which is my some way our biggest market place. I was rather hopeful when I saw that the dependency had been removed from the underlying Firebase library. Is there any possibility of the dependency being linked just to Google Sign which I believe we could do without in the short term? |
@RPCarter53 yeah we'd just have to do some refactoring first! Here's a quick glance at all the places the We need to isolate that usage to just a few files and then guard the usage of those files on some runtime checks for certain classes, otherwise we risk crashing a lot. |
Thanks Sam for the update. I think for now I will go with the underlying firebase-auth and just link with facebook login. I will keep an eye on firebaseUI and pick up when this dependency is gone. |
Welcome to FirebaseUI and thanks for submitting an issue!
Please take a look at open issues, as well as resolved issues, to see if your issue is either already being addressed, or has been solved by someone else.
If not, please feel free to fill in the following info so we can help faster!
Step 1: Are you in the right place?
Step 2: Describe your environment
Step 3: Describe the problem:
The latest release of Firebase-auth has removed the dependency on Google Play Service and yet FirebaseUI-auth still has this dependency. Is there any prospect of this being removed in the near future.
Steps to reproduce:
Observed Results:
logcat
output, etc.Expected Results:
Relevant Code:
The text was updated successfully, but these errors were encountered: