-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Possibility to differentiate between canceled & failed sign in #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#357 has that goal in mind: your activity would have to implement (I'm hoping to find a way around that) public interface SignInResult {
void onAuthUISuccess(IdpResponse data);
void onAuthUIFailure(int resultCode);
} You could get different failure codes from the |
Ok, thank you for the information. |
I have to say that this is currently really a blocker for me regarding usability. The way it is now I have to tell the user that the sign in failed even if he consciously pressed on the back button and cancelled the sign in process. Is there possibly at least some workaround or something similar? I am really a bit struggling (sorry if this is the wrong place to ask for help, please be so kind to redirect me if needed). |
A fix for this issue has been released in version |
There is currently no possibility to differentiate between a canceled sign in (e.g. the user pressed the back button to leave the auth method picker) and a failed sign in attempt.
As far as I can see this always results in
RESULT_CANCELED
as a return code.By consequence it is difficult to show an according message to the user only if the login failed, as for a canceled login I do not want to show an error message (user decided to cancel the login).
Would it be an idea to introduce something like a
RESULT_SIGN_IN_FAILED
return code?Or how is this inteded to be used in general?
The text was updated successfully, but these errors were encountered: