Skip to content

Conversation

@diedu89
Copy link
Contributor

@diedu89 diedu89 commented Sep 12, 2018

Currently if user cancel signin with google an error is shown as a toast instead of the message of user cancellation #1404, to avoid this play-services-auth is upgraded
Also the handle of the error code 12501 is added in order to set an UserCancellationException instead of FirebaseUiException

@diedu89 diedu89 requested a review from samtstern as a code owner September 12, 2018 05:02
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@diedu89
Copy link
Contributor Author

diedu89 commented Sep 12, 2018

I signed it

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@SUPERCILEX SUPERCILEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the styling fixed

@samtstern samtstern added this to the 4.2.0 milestone Sep 12, 2018
@samtstern samtstern changed the base branch from master to version-4.2.0-dev September 12, 2018 16:35
@samtstern samtstern changed the base branch from version-4.2.0-dev to master September 12, 2018 16:35
@samtstern samtstern changed the base branch from master to version-4.2.0-dev September 12, 2018 16:39
@samtstern
Copy link
Contributor

@diedu89 thank you!

@samtstern samtstern merged commit 982f204 into firebase:version-4.2.0-dev Sep 12, 2018
@samtstern
Copy link
Contributor

Merged into the 4.2.0 development branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants