Skip to content

Commit d5e2338

Browse files
authored
fix(ui_auth): correctly position phone input screen footer (#183)
* fix(ui_auth): fix footer position on PhoneInputScreen * chore: increase phone sign in test timeout
1 parent c5e77c2 commit d5e2338

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

packages/firebase_ui_auth/lib/src/screens/phone_input_screen.dart

-11
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ import 'package:firebase_auth/firebase_auth.dart' as fba;
66
import 'package:firebase_ui_shared/firebase_ui_shared.dart';
77
import 'package:flutter/widgets.dart';
88
import 'package:firebase_ui_auth/firebase_ui_auth.dart';
9-
import 'package:firebase_ui_localizations/firebase_ui_localizations.dart';
109

1110
import '../widgets/internal/universal_page_route.dart';
12-
1311
import 'internal/responsive_page.dart';
1412

1513
/// A screen displaying a fully styled phone number entry screen, with a country-code
@@ -107,7 +105,6 @@ class PhoneInputScreen extends StatelessWidget {
107105
@override
108106
Widget build(BuildContext context) {
109107
final flowKey = Object();
110-
final l = FirebaseUILocalizations.labelsOf(context);
111108

112109
return FirebaseUIActions(
113110
actions: actions ?? [SMSCodeRequestedAction(_next)],
@@ -133,14 +130,6 @@ class PhoneInputScreen extends StatelessWidget {
133130
multiFactorSession: multiFactorSession,
134131
mfaHint: mfaHint,
135132
),
136-
const SizedBox(height: 8),
137-
UniversalButton(
138-
text: l.goBackButtonLabel,
139-
variant: ButtonVariant.text,
140-
onPressed: () {
141-
Navigator.of(context).pop();
142-
},
143-
),
144133
],
145134
),
146135
),

packages/firebase_ui_auth/lib/src/views/phone_input_view.dart

+8
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,14 @@ class _PhoneInputViewState extends State<PhoneInputView> {
141141
ErrorText(exception: state.exception),
142142
const SizedBox(height: 8),
143143
],
144+
const SizedBox(height: 8),
145+
UniversalButton(
146+
text: l.goBackButtonLabel,
147+
variant: ButtonVariant.text,
148+
onPressed: () {
149+
Navigator.of(context).pop();
150+
},
151+
),
144152
if (widget.footerBuilder != null) widget.footerBuilder!(context),
145153
],
146154
);

tests/integration_test/firebase_ui_auth/phone_verification_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ void main() {
201201
await tester.testTextInput.receiveAction(TextInputAction.done);
202202
await tester.pumpAndSettle();
203203

204-
final user = await completer.future.timeout(const Duration(seconds: 2));
204+
final user = await completer.future.timeout(const Duration(seconds: 5));
205205

206206
expect(user.phoneNumber, '+1234567890');
207207
},

0 commit comments

Comments
 (0)