feat(ui_auth): allow to toggle password visibility #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
approved these changes
Sep 7, 2023
Comment on lines
+64
to
+73
| Widget buildSuffixIcon() { | ||
| final mIcon = obscureText ? Icons.visibility : Icons.visibility_off; | ||
| final cIcon = obscureText ? CupertinoIcons.eye : CupertinoIcons.eye_slash; | ||
|
|
||
| return UniversalIconButton( | ||
| materialIcon: mIcon, | ||
| cupertinoIcon: cIcon, | ||
| onPressed: () => setState(() => obscureText = !obscureText), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Should we allow a custom icon?
There was a problem hiding this comment.
the whole library tries to follow material and Cupertino spec, so I'd say no.
There was a problem hiding this comment.
could be implemented later if we ever get a feature request for it
russellwheatley
approved these changes
Sep 7, 2023
|
It looks like this feature did not make it to the SignInScreen widget. Is there a plan to add it there? |
ShahoodulHassan
added a commit
to ShahoodulHassan/FirebaseUI-Flutter
that referenced
this pull request
Oct 8, 2023
)" This reverts commit 6e3735d.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #56
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?