Skip to content

🐛 cancelLabel should be capitalized for cancel button or have similar cancelButtonLabel #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
FMorschel opened this issue Oct 10, 2023 · 2 comments · Fixed by #134
Closed
1 task done
Labels
auth bug Something isn't working resolution: fixed A fix has been merged or is pending merge from a PR

Comments

@FMorschel
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and found no duplicates.

What plugin is this bug for?

Firebase UI Localizations

What platform(s) does this bug affect?

Android, iOS, Web, macOS, Linux, Windows

List of dependencies used.

flutter pub deps -s list
...
  - firebase_ui_auth 1.7.0
  - email_validator ^2.0.1
  - firebase_auth ^4.8.0
  - firebase_core ^2.15.0
  - firebase_dynamic_links ^5.3.4
  - firebase_ui_localizations ^1.6.0
  - firebase_ui_oauth ^1.4.10
  - firebase_ui_shared ^1.3.1
  - flutter any
  - flutter_localizations any
- firebase_ui_localizations 1.6.0
  - flutter any
  - flutter_localizations any
  - path ^1.8.2
...

Steps to reproduce

Calling showReauthenticateDialog is strange with a lowercase cancel button.

Expected Behavior

Calling showReauthenticateDialog and seeing a "Cancel" button.

Actual Behavior

Calling showReauthenticateDialog and seeing a "cancel" button.

Additional Information

I'm not sure where you are using the cancelLabel, but I believe this should not be as it is.

PS: Only tested in en-us as of right now.

@darshankawar
Copy link

Thanks for the report @FMorschel
I can't replicate using the plugin example using latest version of it ie, 1.8.2.
I see that you are on 1.7.0. Can you upgrade to latest version and confirm ?
If issue persists, can you provide replicable code sample that shows the behavior reported ?

@darshankawar darshankawar added the blocked: customer response Waiting for customer response, e.g. more information was requested. label Oct 11, 2023
@lesnitsky
Copy link
Member

This is a valid issue. Fix is in #134

@lesnitsky lesnitsky added bug Something isn't working auth and removed blocked: customer response Waiting for customer response, e.g. more information was requested. in triage labels Oct 11, 2023
@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth bug Something isn't working resolution: fixed A fix has been merged or is pending merge from a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants