-
Notifications
You must be signed in to change notification settings - Fork 116
feat(firebase_ui_database): Allow reversing the database query #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_ui_database): Allow reversing the database query #193
Conversation
@Rexios80 could you please merge the latest |
@Rexios80 could you please resolve a conflict and merge the latest main again please? |
…y-builder-reverse
…everse' into feature/database-query-builder-reverse
Hello! Some tests would be great. Otherwise lgtm |
There are no existing tests for the Database UI widgets. Since this is a small change, I believe adding those tests is outside the scope of this PR. |
Oh I saw that you did it for database. We'd want to do it for Firestore too. |
Firestore queries have built-in support for reversal |
You're right, we could use orderBy/descending. LGTM then |
Description
Adds a
reverseQuery
option toFirebaseDatabaseQueryBuilder
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?