Skip to content

feat(firebase_ui_database): Allow reversing the database query #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rexios80
Copy link
Contributor

Description

Adds a reverseQuery option to FirebaseDatabaseQueryBuilder

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Rexios80 Rexios80 changed the title Allow reversing the query for the database query builder feat(firebase_ui_database): Allow reversing the query for the database query builder Nov 22, 2023
@Rexios80 Rexios80 changed the title feat(firebase_ui_database): Allow reversing the query for the database query builder feat(firebase_ui_database): Allow reversing the database query Nov 22, 2023
@lesnitsky
Copy link
Member

@Rexios80 could you please merge the latest main into your branch?

@Rexios80 Rexios80 requested a review from lesnitsky November 24, 2023 14:37
@lesnitsky
Copy link
Member

@Rexios80 could you please resolve a conflict and merge the latest main again please?

@rrousselGit
Copy link
Contributor

Hello!

Some tests would be great. Otherwise lgtm

@Rexios80
Copy link
Contributor Author

Rexios80 commented Dec 6, 2023

There are no existing tests for the Database UI widgets. Since this is a small change, I believe adding those tests is outside the scope of this PR.

@rrousselGit
Copy link
Contributor

Oh I saw that you did it for database. We'd want to do it for Firestore too.

@Rexios80
Copy link
Contributor Author

Rexios80 commented Dec 6, 2023

Firestore queries have built-in support for reversal

@rrousselGit
Copy link
Contributor

You're right, we could use orderBy/descending. LGTM then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants