Skip to content

fix(ui_auth): Fixed a momentary form display after signing in with EmailLinkAuth. #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ywake
Copy link
Contributor

@ywake ywake commented Mar 28, 2024

Description

Fixed an issue where the email address input form was briefly redisplayed upon completing sign-in with EmailLinkAuth.

For now, I've prevented it from going back to the form display, but showing a loading indicator might also be a good idea.

Related Issues

none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ywake ywake changed the title fix(ui_auth) Fixed a momentary form display after signing in with EmailLinkAuth. fix(ui_auth): Fixed a momentary form display after signing in with EmailLinkAuth. Mar 28, 2024
@russellwheatley russellwheatley merged commit 3e37d14 into firebase:main Apr 12, 2024
13 of 17 checks passed
@ywake ywake deleted the hide-form-flash-after-signin branch April 12, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants