feat(ui_firestore): implemented separators and fetching indicator #99

ShahoodulHassan · 2023-09-05T17:41:45Z

Added the following features to FirestoreListView:

show separators between list items
show fetching indicator when the list reaches the end
show both fetching indicator and separators

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (melos run analyze) does not report any problems on my PR.
All unit tests pass (melos run test:unit:all doesn't fail).
I read and followed the Flutter Style Guide.
I signed the CLA.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
No, this is not a breaking change.

- show separators between list items - show loading indicator when the list reaches the end - show both loading indicator and separators

google-cla · 2023-09-05T17:41:49Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

packages/firebase_ui_firestore/lib/src/query_builder.dart

lesnitsky · 2023-10-03T13:05:24Z

format action is failing because new files are generated during melos bootstrap, this was fixed on the main branch, please rebase the latest main to get format green.

ShahoodulHassan · 2023-10-08T14:39:10Z

format action is failing because new files are generated during melos bootstrap, this was fixed on the main branch, please rebase the latest main to get format green.

As a first step, I tried to update the main branch in my fork (using Sync Fork) but I ended up with many errors that I was unable to fix. Is there any other way to achieve this?

lesnitsky · 2023-10-09T11:57:12Z

add an origin to your local git checkout: git remote add upstream git@github.com:firebase/FirebaseUI-Flutter.git
git checkout main
git pull upstream main (syncs the latest main branch of this repo with your fork)
git checkout <your-branch>
git merge main
resolve merge conflicts, if any
commit and push

ShahoodulHassan · 2023-10-10T04:53:41Z

add an origin to your local git checkout: git remote add upstream git@github.com:firebase/FirebaseUI-Flutter.git

git checkout main

git pull upstream main (syncs the latest main branch of this repo with your fork)

git checkout <your-branch>

git merge main

resolve merge conflicts, if any

commit and push

After performing step 3, I get to the same stage where I was using 'Sync fork'.
There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix.
Please let me know how to work around it.

lesnitsky · 2023-10-11T11:09:55Z

There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix.

What errors exactly are you getting?

lesnitsky · 2023-10-19T11:32:17Z

@ShahoodulHassan will you be able to address PR review feedback?

ShahoodulHassan · 2023-10-19T12:16:52Z

Sure I'll provide the feedback on errors by tomorrow max.
Thanks for your patience!

…dicator have been removed. This functionality is now achieved via constructor properties.

ShahoodulHassan · 2023-10-19T13:10:31Z

There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix.

What errors exactly are you getting?

I checked again today and the errors are all gone.

packages/firebase_ui_firestore/lib/src/query_builder.dart

…ngIndicator anymore. 2) showLoadingIndicator is renamed to showFetchingIndicator. FirestoreLoadingIndicatorBuilder is also renamed to FirestoreFetchingIndicatorBuilder accordingly. 3) LoadingIndicator has been used from firebase_ui_shared package 4) Unnecessary comments deleted. 5) BuildAwareWidget is now called OnMountListener and its onBuild method is called onMount. 6) onMount can be called with a delay, that can be configured as per requirement. A default delay of 500ms has been used here to make the fetching indicator show for a bit of a time.

ShahoodulHassan · 2023-11-25T05:52:11Z

@lesnitsky I've incorporated all requested changes via this commit.
Kindly review these and provide your valuable feedback!

packages/firebase_ui_firestore/lib/src/query_builder.dart

lesnitsky

See this comment

lesnitsky · 2023-11-29T18:40:17Z

Please resolve conflicts

ShahoodulHassan · 2023-11-30T13:15:37Z

Please resolve conflicts

Done!

ShahoodulHassan · 2023-11-30T13:18:28Z

See this comment

I've submitted reply to this comment and also resolved the conflicts. Now waiting for your further feedback plz....!

ShahoodulHassan · 2023-11-30T17:53:35Z

@lesnitsky What should I do in order to pass all the failing checks?

lesnitsky · 2023-11-30T22:39:17Z

@ShahoodulHassan I'm taking care of those, no action required from your side.

ShahoodulHassan · 2023-12-12T03:45:07Z

@ShahoodulHassan I'm taking care of those, no action required from your side.

Is it gonna take more time for merging this into the main branch?

Added the following features to FirestoreListView:

836dc31

- show separators between list items - show loading indicator when the list reaches the end - show both loading indicator and separators

ShahoodulHassan changed the title ~~Implemented separators and loading indicator~~ feat: implemented separators and loading indicator Sep 5, 2023

lesnitsky requested changes Oct 3, 2023

View reviewed changes

packages/firebase_ui_firestore/lib/src/query_builder.dart Outdated Show resolved Hide resolved

ShahoodulHassan force-pushed the separated_loading_indicator branch from 1e975bc to 836dc31 Compare October 3, 2023 18:15

lesnitsky changed the title ~~feat: implemented separators and loading indicator~~ feat(ui_firestore): implemented separators and loading indicator Oct 5, 2023

ShahoodulHassan added 2 commits October 19, 2023 17:59

Merge branch 'main' into separated_loading_indicator

49b391e

Separate constructors withLoadingIndicator and separatedWithLoadingIn…

7947765

…dicator have been removed. This functionality is now achieved via constructor properties.

lesnitsky requested changes Nov 23, 2023

View reviewed changes

ShahoodulHassan added 2 commits November 25, 2023 10:34

Added firebase_ui_shared

dcb540c

ShahoodulHassan changed the title ~~feat(ui_firestore): implemented separators and loading indicator~~ feat(ui_firestore): implemented separators and fetching indicator Nov 25, 2023

lesnitsky reviewed Nov 29, 2023

View reviewed changes

packages/firebase_ui_firestore/lib/src/query_builder.dart Show resolved Hide resolved

lesnitsky requested changes Nov 29, 2023

View reviewed changes

ShahoodulHassan added 3 commits November 30, 2023 18:01

Deleted the conflicting lines

eb7b049

Updated firebase_ui_localizations to resolve conflict

3a6d9e9

Merge branch 'main' into separated_loading_indicator

0fe7422

lesnitsky approved these changes Nov 30, 2023

View reviewed changes

lesnitsky added 2 commits November 30, 2023 23:43

fix ui_shared dependency version

8d7fd28

Merge branch 'main' into separated_loading_indicator

3090e44

lesnitsky added 2 commits January 4, 2024 14:09

Merge branch 'main' into separated_loading_indicator

fb178ca

fix: analyzer

40a3e8f

lesnitsky merged commit d8d8bf5 into firebase:main Jan 4, 2024

cnkygmr mentioned this pull request Sep 2, 2024

[firebase_ui_auth] BuildOwner.scheduleBuildFor() called inappropriately. #386

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui_firestore): implemented separators and fetching indicator #99

feat(ui_firestore): implemented separators and fetching indicator #99

ShahoodulHassan commented Sep 5, 2023 •

edited

Loading

google-cla bot commented Sep 5, 2023

lesnitsky commented Oct 3, 2023

ShahoodulHassan commented Oct 8, 2023

lesnitsky commented Oct 9, 2023

ShahoodulHassan commented Oct 10, 2023

lesnitsky commented Oct 11, 2023

lesnitsky commented Oct 19, 2023

ShahoodulHassan commented Oct 19, 2023

ShahoodulHassan commented Oct 19, 2023

ShahoodulHassan commented Nov 25, 2023

lesnitsky left a comment

lesnitsky commented Nov 29, 2023

ShahoodulHassan commented Nov 30, 2023

ShahoodulHassan commented Nov 30, 2023

ShahoodulHassan commented Nov 30, 2023 •

edited

Loading

lesnitsky commented Nov 30, 2023

ShahoodulHassan commented Dec 12, 2023

feat(ui_firestore): implemented separators and fetching indicator #99

feat(ui_firestore): implemented separators and fetching indicator #99

Conversation

ShahoodulHassan commented Sep 5, 2023 • edited Loading

Description

Related Issues

Checklist

Breaking Change

google-cla bot commented Sep 5, 2023

lesnitsky commented Oct 3, 2023

ShahoodulHassan commented Oct 8, 2023

lesnitsky commented Oct 9, 2023

ShahoodulHassan commented Oct 10, 2023

lesnitsky commented Oct 11, 2023

lesnitsky commented Oct 19, 2023

ShahoodulHassan commented Oct 19, 2023

ShahoodulHassan commented Oct 19, 2023

ShahoodulHassan commented Nov 25, 2023

lesnitsky left a comment

Choose a reason for hiding this comment

lesnitsky commented Nov 29, 2023

ShahoodulHassan commented Nov 30, 2023

ShahoodulHassan commented Nov 30, 2023

ShahoodulHassan commented Nov 30, 2023 • edited Loading

lesnitsky commented Nov 30, 2023

ShahoodulHassan commented Dec 12, 2023

ShahoodulHassan commented Sep 5, 2023 •

edited

Loading

ShahoodulHassan commented Nov 30, 2023 •

edited

Loading