Skip to content

option.WithAuthCredentials is broken #721

@oakad

Description

@oakad

option.WithAuthCredentials is presently (v4.18.0) broken in 2 places:

  1. "google.golang.org/[email protected]" will not properly switch to using the "new auth lib". A newer version of google API library is required, such as the recent "google.golang.org/[email protected]".
  2. option.WithScopes, used at present by the implementation will have no effect when option.WithAuthCredentials is specified (assuming p.1). The scopes must be given directly to the constructor of the whatever auth.Credentials object needed; at least this is the case with externalaccount.NewCredentials.
  3. Because of the above, I'd say internal.FirebaseScopes shall be exported from externally visible package. Those scopes are already publicly advertised API feature, not some sort of internal detail (https://developers.google.com/identity/protocols/oauth2/scopes).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions