Skip to content

Allow fcmOptions in payload keys #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/messaging/messaging-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ export interface DataMessagePayload {
[key: string]: string;
}

/* Payload for fcmOptions messages */
export interface FcmOptionsPayload {
analyticsLabel?: string;
[key: string]: string;
}

/* Payload for notification messages */
export interface NotificationMessagePayload {
tag?: string;
Expand All @@ -196,9 +202,10 @@ export interface NotificationMessagePayload {
[other: string]: string;
}

/* Composite messaging payload (data and notification payloads are both optional) */
/* Composite messaging payload (data, fcmOptions, and notification payloads are all optional) */
export interface MessagingPayload {
data?: DataMessagePayload;
fcmOptions?: FcmOptionsPayload;
notification?: NotificationMessagePayload;
}

Expand Down
4 changes: 2 additions & 2 deletions src/messaging/messaging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ export class Messaging implements FirebaseServiceInterface {
const payloadCopy: MessagingPayload = deepCopy(payload);

const payloadKeys = Object.keys(payloadCopy);
const validPayloadKeys = ['data', 'notification'];
const validPayloadKeys = ['data', 'fcmOptions', 'notification'];

let containsDataOrNotificationKey = false;
payloadKeys.forEach((payloadKey) => {
Expand All @@ -744,7 +744,7 @@ export class Messaging implements FirebaseServiceInterface {
throw new FirebaseMessagingError(
MessagingClientErrorCode.INVALID_PAYLOAD,
`Messaging payload contains an invalid "${ payloadKey }" property. Valid properties are ` +
`"data" and "notification".`,
`"data", "fcmOptions", and "notification".`,
);
} else {
containsDataOrNotificationKey = true;
Expand Down
14 changes: 11 additions & 3 deletions test/resources/mocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,11 @@ const mockPayloadNotificationValue = {
body: 'Mock body.',
};

const payload = {
data: mockPayloadDataValue,
notification: mockPayloadNotificationValue,
};

export const messaging = {
topic: 'mock-topic',
topicWithPrefix: '/topics/mock-topic',
Expand All @@ -273,9 +278,12 @@ export const messaging = {
payloadNotificationOnly: {
notification: mockPayloadNotificationValue,
},
payload: {
data: mockPayloadDataValue,
notification: mockPayloadNotificationValue,
payload,
payloadWithFcmOptions: {
...payload,
fcmOptions: {
analyticsLabel: 'test.analytics',
},
},
options: {
collapseKey: 'foo',
Expand Down
10 changes: 10 additions & 0 deletions test/unit/messaging/messaging.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2710,6 +2710,16 @@ describe('Messaging', () => {
);
});

it('should be fulfilled given an options object containing only whitelisted properties with fcmOptions', () => {
mockedRequests.push(mockSendToDeviceStringRequest());

return messaging.sendToTopic(
mocks.messaging.topic,
mocks.messaging.payloadWithFcmOptions,
mocks.messaging.options,
);
});

it('should be fulfilled given an options object containing non-whitelisted properties', () => {
mockedRequests.push(mockSendToDeviceStringRequest());

Expand Down