Mark another flaky test

paulb777 · paulb777 · commit 17fdac8b5394 · 2025-11-29T07:20:45.000-08:00
diff --git a/Crashlytics/UnitTests/FIRCLSSettingsTests.m b/Crashlytics/UnitTests/FIRCLSSettingsTests.m
@@ -296,6 +296,7 @@ - (void)testCacheExpiredFromAppVersion {
   XCTAssertEqual(self.settings.errorLogBufferSize, 128000);
 }
 
+#ifdef FLAKY_TEST
 - (void)testGoogleAppIDChanged {
   NSError *error = nil;
   [self writeSettings:FIRCLSTestSettingsInverse error:&error];
@@ -326,7 +327,6 @@ - (void)testGoogleAppIDChanged {
   XCTAssertEqual(self.settings.errorLogBufferSize, 64 * 1000);
 }
 
-#ifdef FLAKY_TEST
 // This is a weird case where we got settings, but never created a cache key for it. We are
 // treating this as if the cache was invalid and re-fetching in this case.
 - (void)testActivatedSettingsMissingCacheKey {

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,7 @@ - (void)testCacheExpiredFromAppVersion {`
`296`	`296`	`XCTAssertEqual(self.settings.errorLogBufferSize, 128000);`
`297`	`297`	`}`
`298`	`298`
	`299`	`+#ifdef FLAKY_TEST`
`299`	`300`	`- (void)testGoogleAppIDChanged {`
`300`	`301`	`NSError *error = nil;`
`301`	`302`	`[self writeSettings:FIRCLSTestSettingsInverse error:&error];`
`@@ -326,7 +327,6 @@ - (void)testGoogleAppIDChanged {`
`326`	`327`	`XCTAssertEqual(self.settings.errorLogBufferSize, 64 * 1000);`
`327`	`328`	`}`
`328`	`329`
`329`		`-#ifdef FLAKY_TEST`
`330`	`330`	`// This is a weird case where we got settings, but never created a cache key for it. We are`
`331`	`331`	`// treating this as if the cache was invalid and re-fetching in this case.`
`332`	`332`	`- (void)testActivatedSettingsMissingCacheKey {`