Use explicit -n

Author: daymxn

scripts/tests/ai/decrypt_secrets.sh

@@ -22,7 +22,7 @@
 # Expects the environment variable "secrets_passphrase" to be set.
 # This should be set to gpg password for encrypting/decrypting the files.
 
-if [[ ! "${secrets_passphrase}" ]]; then
+if [[ -n "${secrets_passphrase}" ]]; then
   echo "Missing environment variable (secrets_passphrase) to decrypt the files with."
   exit 1
 fi

scripts/tests/ai/run.sh

@@ -48,7 +48,7 @@ set -eo pipefail
 xcode=$1
 
 # Look for Xcode installations if a version wasn't provided explicitly
-if [[ ! "${xcode}" ]]; then
+if [[ -n "${xcode}" ]]; then
     apps=(/Applications/Xcode*.app)
     names=()
     for p in "${apps[@]}"; do
@@ -79,7 +79,7 @@ if [[ $# -gt 1 ]]; then
   target="$2"
 fi
 
-if [[ ! "${TEST_RUNNER_FIRAAppCheckDebugToken}" ]]; then
+if [[ -n "${TEST_RUNNER_FIRAAppCheckDebugToken}" ]]; then
     echo "Missing required environment variable for app check debug token (TEST_RUNNER_FIRAAppCheckDebugToken)"
     exit 1
 fi
@@ -103,7 +103,7 @@ check_for_secret_files () {
 
 cleanup () {
     # We only delete the decrypted secret files if we were the ones to decrypt them.
-    if [[ "${delete_secrets}" ]]; then
+    if [[ -n "${delete_secrets}" ]]; then
         echo "Removing secret files"
         for file in "${secret_files[@]}"; do
             rm -f "${file}"
@@ -116,7 +116,7 @@ cleanup () {
 trap 'exit_code=$?; cleanup; exit "$exit_code"' ERR
 trap 'cleanup' EXIT
 
-if [[ ! "${secrets_passphrase}" ]]; then
+if [[ -n "${secrets_passphrase}" ]]; then
     echo "Environment variable 'secrets_passphrase' wasn't set. Checking if files are already present"
     check_for_secret_files
     echo "Files are present, moving forward"