Skip to content

Commit 2547e15

Browse files
Merge 132bed0 into fc9ec0f
2 parents fc9ec0f + 132bed0 commit 2547e15

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

.changeset/tasty-readers-check.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/firestore": patch
3+
---
4+
5+
Change the networking API to use XHR instead of `fetch()` for ReactNative.

packages/firestore/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"dev": "rollup -c -w",
2121
"lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
2222
"lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
23-
"prettier": "prettier --write '*.js' '*.ts' '@(lite|src|test)/**/*.ts'",
23+
"prettier": "prettier --write '*.js' '@(lite|src|test)/**/*.ts'",
2424
"test:lite": "node ./scripts/run-tests.js --emulator --platform node_lite --main=lite/index.ts 'test/lite/**/*.test.ts'",
2525
"test:lite:prod": "node ./scripts/run-tests.js --platform node_lite --main=lite/index.ts 'test/lite/**/*.test.ts'",
2626
"test:lite:browser": "karma start --single-run --lite",

packages/firestore/src/index.rn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717

1818
import { registerFirestore } from './register';
1919

20-
registerFirestore('rn');
20+
registerFirestore('rn', /* useFetchStreams= */ false);
2121

2222
export * from './api';

packages/firestore/src/register.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ import { setSDKVersion } from '../src/core/version';
2929
import { Firestore } from './api/database';
3030
import { PrivateSettings } from './lite-api/settings';
3131

32-
export function registerFirestore(variant?: string): void {
32+
export function registerFirestore(
33+
variant?: string,
34+
useFetchStreams = true
35+
): void {
3336
setSDKVersion(SDK_VERSION);
3437
_registerComponent(
3538
new Component(
@@ -42,7 +45,7 @@ export function registerFirestore(variant?: string): void {
4245
container.getProvider('auth-internal')
4346
)
4447
);
45-
settings = { useFetchStreams: true, ...settings };
48+
settings = { useFetchStreams, ...settings };
4649
firestoreInstance._setSettings(settings);
4750
return firestoreInstance;
4851
},

packages/firestore/test/integration/remote/remote.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe('Remote Storage', () => {
5353
});
5454
});
5555

56-
it('can read deleted documents', () => {
56+
it.only('can read deleted documents', () => {
5757
return withTestDatastore(async ds => {
5858
const k = key('docs/2');
5959

0 commit comments

Comments
 (0)