Removing RxFire (#4332)

* RxFire is moving to its own repo

* Updating link

Co-authored-by: Feiyang1 <[email protected]>

Author: jamesdaniels

.github/CODEOWNERS

@@ -62,9 +62,6 @@ packages/auth-types  @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk
 packages/testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
 
-# RxFire Code
-packages/rxfire @davideast @jamesdaniels @firebase/jssdk-global-approvers
-
 # Installations
 packages/installations @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
 packages/installations-types @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers

.github/workflows/canary-deploy.yml

@@ -60,5 +60,4 @@ jobs:
         NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
         NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
         NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
-        NPM_TOKEN_RXFIRE: ${{secrets.NPM_TOKEN_RXFIRE}}
         CI: true

.github/workflows/prerelease-manual-deploy.yml

@@ -61,6 +61,5 @@ jobs:
             NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
             NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
             NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
-            NPM_TOKEN_RXFIRE: ${{secrets.NPM_TOKEN_RXFIRE}}
             CI: true
 

.github/workflows/test-changed-misc.yml

@@ -1,4 +1,4 @@
-name: Test rxFire and @firebase/rules-unit-testing
+name: Test @firebase/rules-unit-testing
 
 on: pull_request
 

package.json

@@ -21,12 +21,12 @@
     "performance"
   ],
   "scripts": {
-    "dev": "lerna run --parallel --scope @firebase/* --scope firebase --scope rxfire dev",
-    "build": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --scope rxfire --ignore @firebase/app-exp build",
+    "dev": "lerna run --parallel --scope @firebase/* --scope firebase dev",
+    "build": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --ignore @firebase/app-exp build",
     "build:exp": "lerna run --scope @firebase/*-exp --scope @firebase/*-compat --scope firebase-exp build",
-    "build:release": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --scope rxfire --ignore @firebase/*-exp --ignore @firebase/*-compat build",
+    "build:release": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --ignore @firebase/*-exp --ignore @firebase/*-compat build",
     "build:changed": "ts-node-script scripts/ci-test/build_changed.ts",
-    "link:packages": "lerna exec --scope @firebase/* --scope firebase --scope rxfire -- yarn link",
+    "link:packages": "lerna exec --scope @firebase/* --scope firebase -- yarn link",
     "stage:packages": "./scripts/prepublish.sh",
     "repl": "node tools/repl.js",
     "release": "ts-node-script scripts/release/cli.ts",
@@ -46,8 +46,8 @@
     "docgen:node": "node scripts/docgen/generate-docs.js --api node",
     "docgen": "yarn docgen:js; yarn docgen:node",
     "prettier": "prettier --config .prettierrc --write '**/*.{ts,js}'",
-    "lint": "lerna run --scope @firebase/* --scope rxfire lint",
-    "lint:fix": "lerna run --scope @firebase/* --scope rxfire lint:fix",
+    "lint": "lerna run --scope @firebase/* lint",
+    "lint:fix": "lerna run --scope @firebase/* lint:fix",
     "size-report": "ts-node-script scripts/size_report/report_binary_size.ts",
     "modular-export-size-report": "ts-node-script scripts/size_report/report_modular_export_binary_size.ts",
     "api-report": "lerna run --scope @firebase/*-exp --scope @firebase/firestore --scope @firebase/storage --scope @firebase/storage-types --scope @firebase/database api-report",

packages/rules-unit-testing/src/api/index.ts

@@ -263,7 +263,9 @@ export function initializeAdminApp(options: AdminAppOptions): app.App {
  * @param options options object.
  */
 export function useEmulators(options: FirebaseEmulatorOptions): void {
-  if (!(options.database || options.firestore || options.storage || options.hub)) {
+  if (
+    !(options.database || options.firestore || options.storage || options.hub)
+  ) {
     throw new Error(
       "Argument to useEmulators must contain at least one of 'database', 'firestore', 'storage', or 'hub'."
     );
@@ -429,7 +431,7 @@ function getHubHost() {
 }
 
 function parseHost(host: string): { hostname: string; port: number } {
-  const withProtocol = host.startsWith("http") ? host : `http://${host}`;
+  const withProtocol = host.startsWith('http') ? host : `http://${host}`;
   const u = new URL(withProtocol);
   return {
     hostname: u.hostname,

packages/rules-unit-testing/test/database.test.ts

@@ -279,7 +279,7 @@ describe('Testing Module Tests', function () {
     // TODO: This test cannot be enabled without adding credentials to the test environment
     //       due to an underlying issue with firebase-admin storage. For now we will run it
     //       locally but not in CI.
-    if (process.env.CI !== "true") {
+    if (process.env.CI !== 'true') {
       await firebase.assertSucceeds(
         app.storage().bucket().file('/foo/bar.txt').save('Hello, World!')
       );