Skip to content

Commit f73b24d

Browse files
authored
Skip large sized bloom filter golden tests (#7537)
1 parent 6c7d079 commit f73b24d

File tree

1 file changed

+28
-15
lines changed

1 file changed

+28
-15
lines changed

packages/firestore/test/unit/remote/bloom_filter.test.ts

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -198,25 +198,38 @@ describe('BloomFilter', () => {
198198
TEST_DATA.count5000Rate0001TestResult
199199
);
200200
});
201-
it('mightContain result for 50000 documents with 1 false positive rate', () => {
201+
202+
// Skip large sized golden tests as they slow down unit test runs without significantly
203+
// improving coverage compared to other golden tests.
204+
// These tests can be run manually if needed.
205+
// eslint-disable-next-line no-restricted-properties
206+
it.skip('mightContain result for 50000 documents with 1 false positive rate', () => {
202207
testBloomFilterAgainstExpectedResult(
203208
TEST_DATA.count50000Rate1TestData,
204209
TEST_DATA.count50000Rate1TestResult
205210
);
206211
});
207-
it('mightContain result for 50000 documents with 0.01 false positive rate', () => {
208-
testBloomFilterAgainstExpectedResult(
209-
TEST_DATA.count50000Rate01TestData,
210-
TEST_DATA.count50000Rate01TestResult
211-
);
212-
//Extend default timeout(2000)
213-
}).timeout(10_000);
214-
it('mightContain result for 50000 documents with 0.0001 false positive rate', () => {
215-
testBloomFilterAgainstExpectedResult(
216-
TEST_DATA.count50000Rate0001TestData,
217-
TEST_DATA.count50000Rate0001TestResult
218-
);
219-
//Extend default timeout(2000)
220-
}).timeout(10_000);
212+
// eslint-disable-next-line no-restricted-properties
213+
it.skip(
214+
'mightContain result for 50000 documents with 0.01 false positive rate',
215+
() => {
216+
testBloomFilterAgainstExpectedResult(
217+
TEST_DATA.count50000Rate01TestData,
218+
TEST_DATA.count50000Rate01TestResult
219+
);
220+
// Extend the default timeout to 10000ms
221+
}
222+
).timeout(10_000);
223+
// eslint-disable-next-line no-restricted-properties
224+
it.skip(
225+
'mightContain result for 50000 documents with 0.0001 false positive rate',
226+
() => {
227+
testBloomFilterAgainstExpectedResult(
228+
TEST_DATA.count50000Rate0001TestData,
229+
TEST_DATA.count50000Rate0001TestResult
230+
);
231+
// Extend the default timeout to 10000ms
232+
}
233+
).timeout(10_000);
221234
});
222235
});

0 commit comments

Comments
 (0)