We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can submit PR if this should be fixed.
firebase-js-sdk passes non-error object to Promise.reject. This causes getsentry/sentry-javascript#2546.
I have no idea to reproduce this, but Sentry receive unhandled promise rejection of non-error object.
onerror event is passed to reject. But onerror event is not an Error object. We need to wrap the event with Error class I think.
onerror
reject
Error
firebase-js-sdk/packages-exp/auth-exp/src/platform_browser/load_js.ts
Line 28 in 5ad7ff2
The text was updated successfully, but these errors were encountered:
sam-gc
Successfully merging a pull request may close this issue.
I can submit PR if this should be fixed.
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
Steps to reproduce:
firebase-js-sdk passes non-error object to Promise.reject. This causes getsentry/sentry-javascript#2546.
I have no idea to reproduce this, but Sentry receive unhandled promise rejection of non-error object.
Relevant Code:
onerror
event is passed toreject
. Butonerror
event is not anError
object. We need to wrap the event withError
class I think.firebase-js-sdk/packages-exp/auth-exp/src/platform_browser/load_js.ts
Line 28 in 5ad7ff2
The text was updated successfully, but these errors were encountered: