Skip to content

Commit 48156bc

Browse files
wrapper method that causes duplicate symbols
1 parent 18ad50d commit 48156bc

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

Package.swift

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,21 @@ let package = Package(
1616
.iOS("13.0"),
1717
],
1818
products: [
19-
.library(name: "remote-firebase-core", targets: ["remote_firebase_core"]),
20-
],
21-
dependencies: [
22-
.package(path: "packages/firebase_core/firebase_core/ios/firebase_core"),
19+
.library(name: "firebase-core-target", targets: ["firebase_core_target"]),
2320
],
2421
targets: [
2522
.target(
26-
name: "remote_firebase_core",
27-
dependencies: [
28-
// Add the firebase_core package as a dependency
29-
.product(name: "firebase-core", package: "firebase_core"),
30-
]
23+
name: "firebase_core_target",
24+
dependencies:[
25+
.target(name: "firebase_core")
26+
],
27+
path: "Sources/firebase_core_target"
28+
),
29+
.target(
30+
name: "firebase_core",
31+
path: "packages/firebase_core/firebase_core/ios/firebase_core",
32+
exclude: ["Package.swift"],
33+
publicHeadersPath: "Sources/firebase_core/include"
3134
),
3235
]
3336
)

packages/cloud_firestore/cloud_firestore/ios/cloud_firestore/Package.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,19 @@ let package = Package(
7171
],
7272
dependencies: [
7373
.package(url: "https://github.com/firebase/firebase-ios-sdk", from: firebase_sdk_version),
74+
// This works
75+
// .package(name:"flutterfire", path: "../../../../.."),
7476
// TODO - this needs a version instead
75-
.package(url:"https://github.com/firebase/flutterfire", branch: "spm-firestore"),
77+
// This isn't working
78+
.package(url:"https://github.com/russellwheatley/test-flutterfire", exact: "0.0.19"),
7679
],
7780
targets: [
7881
.target(
7982
name: "cloud_firestore",
8083
dependencies: [
8184
.product(name: "FirebaseFirestore", package: "firebase-ios-sdk"),
8285
// Wrapper dependency
83-
.product(name: "remote-firebase-core", package: "flutterfire")
86+
.product(name: "firebase-core-wrapper", package: "test-flutterfire")
8487
],
8588
resources: [
8689
.process("Resources"),

0 commit comments

Comments
 (0)