Skip to content

fix(ui_auth): unfocus to dismiss keyboard when submitting email form #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

plammens
Copy link
Contributor

@plammens plammens commented Jan 2, 2023

Description

Currently, when clicking the Sign In button, the in-screen keyboard is not dismissed. This PR automatically dismisses the keyboard (by unfocusing) when the form is submitted.

Related Issues

Fixes #10207

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix: Unfocus to dismiss keyboard when submitting email form fix(firebase_auth_ui): unfocus to dismiss keyboard when submitting email form Jan 5, 2023
@lesnitsky lesnitsky marked this pull request as ready for review January 6, 2023 13:07
@lesnitsky lesnitsky self-requested a review as a code owner January 6, 2023 13:07
@lesnitsky lesnitsky changed the title fix(firebase_auth_ui): unfocus to dismiss keyboard when submitting email form fix(ui_auth): unfocus to dismiss keyboard when submitting email form Jan 6, 2023
@lesnitsky lesnitsky requested review from Lyokone and pr-Mais January 6, 2023 13:08
@lesnitsky lesnitsky merged commit f3a4d3a into firebase:master Jan 11, 2023
@lesnitsky
Copy link
Member

@plammens thanks

@firebase firebase locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_ui_auth] SignInScreen error messages can be hidden by the in-screen keyboard on some devices
3 participants