🐛 [firebase_core_web] is throwing an exception when running in debug mode and asking the IDE to catch all exceptions

[wer-mathurin]

Bug report

In production is not a problem, the exception is not preventing the application to crash...but when debuging code (in VS code) is very common to is very common to activate:

and you will get this error:

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce

Run the app with device Chrome.

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();

  await Firebase.initializeApp(
    options: DefaultFirebaseOptions.currentPlatform,
  );

  runApp(const App());
}

class App extends StatelessWidget {
  const App({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Container();
  }
}

Expected behavior

Current code that interpreted as Uncaught Exceptions in VS Code and this look strange since this is catched!

List<String> get _ignoredServiceScripts {
   try {
     JsObject ignored =
         JsObject.fromBrowserObject(context['flutterfire_ignore_scripts']);

     if (ignored is Iterable) {
       return (ignored as Iterable)
           .map((e) => e.toString())
           .toList(growable: false);
     }
   } catch (e) {
     // Noop
   }

   return [];
 }

But if we want to resolve this we can always do this:

List<String> get _ignoredServiceScripts {
   try {
     final ignoreScripts = context['flutterfire_ignore_scripts'];
     if (ignoreScripts == null) return [];

     JsObject ignored = JsObject.fromBrowserObject(ignoreScripts);

     if (ignored is Iterable) {
       return (ignored as Iterable)
           .map((e) => e.toString())
           .toList(growable: false);
     }
   } catch (e) {
     // Noop
   }

   return [];
 }

[darshankawar]

Thanks for the report @wer-mathurin
Can you take a look at #10468 and underlying comments and see if they help in your case or not ?

[wer-mathurin]

@darshankawar that's my point, the latest solution identified in the ticket you referenced is not working as expected. Uncaught exception still bring us to the failing code !

But we can argue that relying on exception to detect undefined value in the configuration is not self explanatory.

This is an easy PR to do and will make the code more.clear to me and solve this issue that is raised multiple time.

Any thoughts?

[darshankawar]

Thanks for the feedback @wer-mathurin
I am wondering if this is related to dart specifically and it's effect rippled to flutterfire plugins. See dart-lang/sdk#53334 and check if it helps further or not.

[google-oss-bot]

Hey @wer-mathurin. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

[wer-mathurin]

@darshankawar maybe this is related. Can we let the ticket open until the hotfix land and see if this resolve the issue

[darshankawar]

Ok, will keep it open for now.

[russellwheatley]

The hot fix mentioned by @darshankawar has landed in Flutter, @wer-mathurin (in Flutter version >= v3.13.4). Could you try it out and see if it addresses your issue?

[google-oss-bot]

Hey @wer-mathurin. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

[google-oss-bot]

Since there haven't been any recent updates here, I am going to close this issue.

@wer-mathurin if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.