Refactor the way HTTP responses are generated from Results

[alxiord]

The following piece of code:

sender
    .send(Box<Something>)
    .map_err(|_| ())
    .expect("one-shot channel closed")

appears an awful lot throughout the code. We could make the code prettier by having a helper function which hides having to type these lines again and again. If we want to go to the next beauty level, we could implement the GenerateResponse trait for a Result, like this:

impl<V, E> GenerateResponse for Result<V, E> 
    where V: GenerateResponse,
               E: GenerateResponse {
    fn generate_response(&self) -> Response {
        return match self {
            Ok(v) => v.generate_response(),
            Err(e) => e.generate_response() 
        }
    }
}

This basically says that if both the Ok and the Err parts of a Result implement GenerateResponse, then the Result itself implements GenerateResponse, so we can send the Result variable through the channel without extracting the actual inner value first.

[andreeaflorescu]

Not anymore 💃