[SH] test(memory_overhead): update x86 mmio gap start #5565
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following commit we resized the 32b MMIO region to 1GiB, but it was not reflected in the test: commit 7c623e8 Author: Babis Chalios <[email protected]> Date: Mon May 5 17:52:08 2025 +0200 arch: define 64-bit capable MMIO memory regions Signed-off-by: Nikita Kalyazin <[email protected]>
Manciukic
approved these changes
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5565 +/- ##
=========================================================
- Coverage 82.35% 82.32% -0.04%
=========================================================
Files 277 277
Lines 29900 29900
=========================================================
- Hits 24625 24614 -11
- Misses 5275 5286 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
approved these changes
Dec 5, 2025
kalyazin
merged commit 5c96a4c
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #5563 .
Changes
test(memory_overhead): update x86 mmio gap start
Reason
In the following commit we resized the 32b MMIO region to 1GiB, but it was not reflected in the test:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.