Skip to content

Applied Ben's comments on PR #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NasserFlexCompute merged 1 commit into from
Oct 22, 2025
Merged

Applied Ben's comments on PR #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flow360/component/simulation/meshing_param/face_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ class GeometryRefinement(Flow360BaseModel):
+ "to geometry_accuracy should be resolved accurately during the surface meshing process.",
)

sealing_size: Optional[LengthType.NonNegative] = pd.Field(
sealing_size: LengthType.NonNegative = pd.Field(
0.0 * u.m,
description="Threshold size below which all geometry gaps are automatically closed. Zero is deactivated.",
description="Threshold size below which all geometry gaps are automatically closed.",
)

# Note: No checking on deleted surfaces since geometry accuracy on deleted surface does impact the volume mesh.
Expand Down
4 changes: 2 additions & 2 deletions flow360/component/simulation/meshing_param/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,10 @@ class MeshingDefaults(Flow360BaseModel):
+ "This can be overridden with class: ~flow360.GeometryRefinement",
)

sealing_size: Optional[LengthType.NonNegative] = pd.Field(
sealing_size: LengthType.NonNegative = pd.Field(
0.0 * u.m,
description="Threshold size below which all geometry gaps are automatically closed. "
+ "Zero is deactivated. This can be overridden with class: ~flow360.GeometryRefinement",
+ "This can be overridden with class: ~flow360.GeometryRefinement",
)

@pd.field_validator("number_of_boundary_layers", mode="after")
Expand Down
Loading