Skip to content

[SCFD-6683] Fixed validation when enclosed entities is None #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 2 commits into from
Nov 4, 2025
Merged

[SCFD-6683] Fixed validation when enclosed entities is None #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46cf570
[SCFD-6683] Fixed validaiton when enclosed entities is NOne
benflexcompute Nov 4, 2025
7b797a0
Use default instead
benflexcompute Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flow360/component/simulation/meshing_param/volume_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def _validate_enclosed_box_only_in_beta_mesher(cls, values):
The current prefix is 'rotatingBlock-' with 14 characters.
"""
validation_info = get_validation_info()
if validation_info is None:
if validation_info is None or values is None:
return values
if validation_info.is_beta_mesher:
return values
Expand Down
18 changes: 18 additions & 0 deletions tests/simulation/params/meshing_validation/test_meshing_param_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,3 +475,21 @@ def test_enforced_half_model_only_in_beta_mesher():
):
with ValidationContext(VOLUME_MESH, non_gai_context):
AutomatedFarfield(domain_type="full_body")


def test_enclosed_entities_none_does_not_raise():
with CGS_unit_system:
cylinder = Cylinder(
name="cylinder",
outer_radius=1,
height=12,
axis=(0, 1, 0),
center=(0, 5, 0),
)
# Should not raise even when enclosed_entities is explicitly None
_ = RotationVolume(
entities=[cylinder],
spacing_axial=20,
spacing_radial=0.2,
spacing_circumferential=20,
)
Loading