From 0630161e6f3fff42d2a8a95ad898f26218d9382e Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Thu, 14 Nov 2024 15:56:38 -0800 Subject: [PATCH] [Impeller] Don't enable KHR_debug on Angle. All it does it log the calls and overwhelms the output for no utility. --- impeller/renderer/backend/gles/description_gles.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/impeller/renderer/backend/gles/description_gles.cc b/impeller/renderer/backend/gles/description_gles.cc index 855c192079a6b..fa01bbb8705a3 100644 --- a/impeller/renderer/backend/gles/description_gles.cc +++ b/impeller/renderer/backend/gles/description_gles.cc @@ -178,7 +178,10 @@ bool DescriptionGLES::HasExtension(const std::string& ext) const { } bool DescriptionGLES::HasDebugExtension() const { - return HasExtension("GL_KHR_debug"); + // Angle just logs calls instead of forwarding debug information to the + // backend. This just overwhelms the logs and is of limited use. Disable on + // Angle. + return HasExtension("GL_KHR_debug") && !IsANGLE(); } } // namespace impeller