Skip to content

Commit e3ea847

Browse files
committed
Apply review suggestions
1 parent 8795826 commit e3ea847

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
name: release
1+
name: Release
2+
23
on:
34
pull_request:
45
push:
@@ -16,16 +17,13 @@ jobs:
1617
- uses: actions/checkout@v2
1718
with:
1819
fetch-depth: 2
19-
- name: Set up tools
20-
run: dart pub get
21-
working-directory: ${{ github.workspace }}/tools
2220
- name: Dry run on pull request
2321
if: ${{ github.event_name == 'pull_request' }}
2422
run: |
2523
./tools/tools_runner.sh publish-plugin \
2624
--all-changed \
2725
--pub-publish-flags=--dry-run \
28-
--base-sha=$(git rev-parse HEAD~)
26+
--base-sha=HEAD~
2927
- name: Wait on all tests
3028
if: ${{ github.event_name == 'push' }}
3129
uses: lewagon/[email protected]
@@ -39,10 +37,6 @@ jobs:
3937
- name: Publish plugins
4038
if: ${{ github.event_name == 'push' }}
4139
run: |
42-
./tools/tools_runner.sh publish-plugin \
43-
--all-changed \
44-
--pub-publish-flags=--dry-run \
45-
--base-sha=HEAD~ \
4640
./tools/tools_runner.sh publish-plugin \
4741
--all-changed \
4842
--base-sha=HEAD~ \

tools/lib/src/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ import 'package:file/local.dart';
1111
import 'package:flutter_plugin_tools/src/common/core.dart';
1212
import 'package:flutter_plugin_tools/src/format_command.dart';
1313
import 'package:flutter_plugin_tools/src/list_command.dart';
14-
import 'package:flutter_tizen_plugin_tools/src/publish_plugin_command.dart';
1514

1615
import 'build_examples_command.dart';
1716
import 'integration_test_command.dart';
17+
import 'publish_plugin_command.dart';
1818

1919
void main(List<String> args) {
2020
const FileSystem fileSystem = LocalFileSystem();

tools/lib/src/publish_plugin_command.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class PublishPluginCommand extends PackageLoopingCommand {
6060
argParser.addFlag(
6161
_dryRunFlag,
6262
help:
63-
'Skips the real `pub publish` and `git tag` commands and assumes both commands are successful.\n'
63+
'Skips the real `pub publish` command and assumes the command is successful.\n'
6464
'This does not run `pub publish --dry-run`.\n'
6565
'If you want to run the command with `pub publish --dry-run`, use `pub-publish-flags=--dry-run`',
6666
defaultsTo: false,

0 commit comments

Comments
 (0)