Skip to content

Make IntelliJ LSP Client compilable against 2025.3#476

Merged
helin24 merged 1 commit into
flutter:mainfrom
alexander-doroshko:compatibility-with-2025.3
Jun 18, 2026
Merged

Make IntelliJ LSP Client compilable against 2025.3#476
helin24 merged 1 commit into
flutter:mainfrom
alexander-doroshko:compatibility-with-2025.3

Conversation

@alexander-doroshko

Copy link
Copy Markdown
Contributor

@helin24

This PR makes the code in the third_party/thirdPartySrc/platform-lsp folder compilable against Android Studio Panda and IntelliJ IDEA 2025.3. The code stays compilable against 2026.1 and 2026.2.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates blocking read actions to non-blocking alternatives across several LSP implementation files and configures the Dart language for the import optimizer. Feedback focuses on avoiding commented-out code or modifiers and addressing a bypassed canFormat check in LspImportOptimizer by using it.canFormat(psiFile) instead.

@alexander-doroshko

Copy link
Copy Markdown
Contributor Author

This pull request migrates blocking read actions to non-blocking alternatives across several LSP implementation files

No, it doesn't :). I simply replaced new API calls to deprecated API calls that are 100% equivalent. This deprecated API is not going to be deleted any time soon, so it's safe to use it

@alexander-doroshko alexander-doroshko force-pushed the compatibility-with-2025.3 branch from 704999b to ae2b063 Compare June 16, 2026 13:45
@alexander-doroshko alexander-doroshko force-pushed the compatibility-with-2025.3 branch from ae2b063 to f3bbce3 Compare June 16, 2026 15:12

@helin24 helin24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. My only outstanding questions are:

  • These changes aren't going into intellij-community, right? Since that is available for 2026.2?
  • Can we add these patches to the existing skill so we can reapply if we need to copy over these files again?

@alexander-doroshko

Copy link
Copy Markdown
Contributor Author

This LGTM. My only outstanding questions are:

These changes aren't going into intellij-community, right? Since that is available for 2026.2?
Can we add these patches to the existing skill so we can reapply if we need to copy over these files again?

Discussed by email

@helin24 helin24 merged commit f34f3e9 into flutter:main Jun 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants