Skip to content

Report usage analytics for Dart run and debug sessions#478

Merged
helin24 merged 1 commit into
flutter:mainfrom
helin24:dap
Jun 22, 2026
Merged

Report usage analytics for Dart run and debug sessions#478
helin24 merged 1 commit into
flutter:mainfrom
helin24:dap

Conversation

@helin24

@helin24 helin24 commented Jun 16, 2026

Copy link
Copy Markdown
Member

I've been looking into using JetBrains DAP, which would allow us to remove usages of the legacy analysis server for file mapping (this functionality does not exist in LSP analysis server because debug adapter in Dart SDK takes care of it). DAP seems promising, but I also want to check the usage of the current run/debug mechanisms. Then if we transition, we will be able to check whether we are getting equivalent usage, and the relative numbers of users may also inform how much time we spend on verifying DAP setups before releasing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements analytics tracking for run and debug sessions across various Dart run configurations (command line, remote debug, webdev, and tests) using a new recordRunOrDebugSession helper. The review feedback correctly identifies that the newly added DebugSessionData class and its companion factory method forDebugSession are unused and redundant, as the generic SessionData class can handle both session types.

Comment thread third_party/src/main/java/com/jetbrains/lang/dart/analytics/Analytics.kt Outdated
Comment thread third_party/src/main/java/com/jetbrains/lang/dart/analytics/Analytics.kt Outdated
…chanisms

Add telemetry reporting to all Dart run configurations to track how often users initiate Run or Debug sessions across mechanisms: standard CLI apps, Dart tests, remote attaches, and Webdev sessions.
@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Jun 22, 2026
@auto-submit auto-submit Bot removed the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Jun 22, 2026
@auto-submit

auto-submit Bot commented Jun 22, 2026

Copy link
Copy Markdown

autosubmit label was removed for flutter/dart-intellij-third-party/478, because - The status or check suite build-plugin has failed. Please fix the issues identified (or deflake) before re-applying this label.

@helin24 helin24 merged commit 9e28c92 into flutter:main Jun 22, 2026
16 of 17 checks passed
@helin24 helin24 deleted the dap branch June 22, 2026 19:20
auto-submit Bot pushed a commit to flutter/flutter-intellij that referenced this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants