Remove unused code (#5301)

Removes unused code, detected by `check-unused-code`.

Author: incendial

packages/devtools_app/integration_test/test_infra/run/_test_app_driver.dart

@@ -15,8 +15,6 @@ class TestFlutterApp extends _TestApp {
   TestFlutterApp({String appPath = 'test/test_infra/fixtures/flutter_app'})
       : super(appPath);
 
-  Directory get workingDirectory => Directory(testAppPath);
-
   @override
   Future<void> startProcess() async {
     runProcess = await Process.start(

packages/devtools_app/lib/src/app.dart

@@ -242,7 +242,6 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
               providers: _providedControllers(),
               child: DevToolsScaffold(
                 embed: embed,
-                ideTheme: ideTheme,
                 page: page,
                 screens: screens,
                 actions: [

packages/devtools_app/lib/src/framework/initializer.dart

@@ -10,6 +10,7 @@ import 'package:flutter/material.dart';
 import '../shared/analytics/analytics.dart' as ga;
 import '../shared/analytics/constants.dart' as gac;
 import '../shared/common_widgets.dart';
+import '../shared/framework_controller.dart';
 import '../shared/globals.dart';
 import '../shared/primitives/auto_dispose.dart';
 import '../shared/primitives/utils.dart';
@@ -104,7 +105,7 @@ class _InitializerState extends State<Initializer>
   /// Connects to the VM with the given URI. This request usually comes from the
   /// IDE via the server API to reuse the DevTools window after being disconnected
   /// (for example if the user stops a debug session then launches a new one).
-  void _connectVm(event) {
+  void _connectVm(ConnectVmEvent event) {
     DevToolsRouterDelegate.of(context).updateArgsIfChanged({
       'uri': event.serviceProtocolUri.toString(),
       if (event.notify) 'notify': 'true',

packages/devtools_app/lib/src/framework/scaffold.dart

@@ -41,7 +41,6 @@ class DevToolsScaffold extends StatefulWidget {
     this.page,
     this.actions,
     this.embed = false,
-    required this.ideTheme,
   }) : super(key: key);
 
   DevToolsScaffold.withChild({
@@ -52,7 +51,6 @@ class DevToolsScaffold extends StatefulWidget {
   }) : this(
           key: key,
           screens: [SimpleScreen(child)],
-          ideTheme: ideTheme,
           actions: actions,
         );
 
@@ -85,9 +83,6 @@ class DevToolsScaffold extends StatefulWidget {
   /// Whether to render the embedded view (without the header).
   final bool embed;
 
-  /// IDE-supplied theming.
-  final IdeTheme ideTheme;
-
   /// Actions that it's possible to perform in this Scaffold.
   ///
   /// These will generally be [RegisteredServiceExtensionButton]s.

packages/devtools_app/lib/src/screens/debugger/codeview.dart

@@ -282,7 +282,7 @@ class _CodeViewState extends State<CodeView>
         return Stack(
           children: [
             scriptRef == null
-                ? CodeViewEmptyState(widget: widget, context: context)
+                ? CodeViewEmptyState(widget: widget)
                 : buildCodeArea(context),
             if (showFileOpener)
               Positioned(
@@ -544,11 +544,9 @@ class CodeViewEmptyState extends StatelessWidget {
   const CodeViewEmptyState({
     super.key,
     required this.widget,
-    required this.context,
   });
 
   final CodeView widget;
-  final BuildContext context;
 
   @override
   Widget build(BuildContext context) {
@@ -619,10 +617,7 @@ class ProfileInformationGutter extends StatelessWidget {
                       if (data == null) {
                         return const SizedBox();
                       }
-                      return ProfileInformationGutterItem(
-                        lineNumber: lineNum,
-                        profilerData: data,
-                      );
+                      return ProfileInformationGutterItem(profilerData: data);
                     },
                   ),
                 ),
@@ -692,12 +687,9 @@ class _ProfileInformationGutterHeader extends StatelessWidget {
 class ProfileInformationGutterItem extends StatelessWidget {
   const ProfileInformationGutterItem({
     Key? key,
-    required this.lineNumber,
     required this.profilerData,
   }) : super(key: key);
 
-  final int lineNumber;
-
   final ProfileReportEntry profilerData;
 
   @override

packages/devtools_app/lib/src/screens/debugger/debugger_model.dart

@@ -253,15 +253,6 @@ class FileNode extends TreeNode<FileNode> {
   /// This exists to allow for O(1) lookup of children when building the tree.
   final Map<String, FileNode> _childrenAsMap = {};
 
-  bool get hasScript => scriptRef != null;
-
-  String _fileName = '';
-
-  /// Returns the name of the file.
-  ///
-  /// May be empty.
-  String get fileName => _fileName;
-
   /// Given a flat list of service protocol scripts, return a tree of scripts
   /// representing the best hierarchical grouping.
   static List<FileNode> createRootsFrom(List<ScriptRef> scripts) {
@@ -278,7 +269,6 @@ class FileNode extends TreeNode<FileNode> {
       }
 
       node.scriptRef = script;
-      node._fileName = ScriptRefUtils.fileName(script);
     }
 
     // Clear out the _childrenAsMap map.

packages/devtools_app/lib/src/screens/debugger/program_explorer.dart

@@ -21,7 +21,6 @@ import 'program_explorer_model.dart';
 
 const containerIcon = Icons.folder;
 const libraryIcon = Icons.insert_drive_file;
-const listItemHeight = 40.0;
 
 double get _programExplorerRowHeight => scaleByFontFactor(22.0);
 double get _selectedNodeTopSpacing => _programExplorerRowHeight * 3;
@@ -428,14 +427,12 @@ class ProgramExplorer extends StatelessWidget {
     required this.controller,
     this.title = 'File Explorer',
     this.onNodeSelected,
-    this.displayCodeNodes = false,
     this.displayHeader = true,
   });
 
   final ProgramExplorerController controller;
   final String title;
   final void Function(VMServiceObjectNode)? onNodeSelected;
-  final bool displayCodeNodes;
   final bool displayHeader;
 
   @override

packages/devtools_app/lib/src/screens/inspector/inspector_data_models.dart

@@ -128,23 +128,6 @@ class LayoutProperties {
     }
   }
 
-  factory LayoutProperties.lerp(
-    LayoutProperties begin,
-    LayoutProperties end,
-    double t,
-  ) {
-    return LayoutProperties.values(
-      node: end.node,
-      children: end.children,
-      constraints: BoxConstraints.lerp(begin.constraints, end.constraints, t),
-      description: end.description,
-      flexFactor: begin.flexFactor! * (t + 1) - end.flexFactor! * t,
-      isFlex: begin.isFlex && end.isFlex,
-      size: Size.lerp(begin.size, end.size, t)!,
-      flexFit: end.flexFit,
-    );
-  }
-
   LayoutProperties? parent;
   final RemoteDiagnosticsNode node;
   final List<LayoutProperties> children;

packages/devtools_app/lib/src/screens/inspector/layout_explorer/box/box.dart

@@ -377,8 +377,6 @@ class BoxChildVisualizer extends StatelessWidget {
   final LayoutProperties layoutProperties;
   final RenderProperties renderProperties;
 
-  LayoutProperties? get root => state.properties;
-
   LayoutProperties? get properties => renderProperties.layoutProperties;
 
   @override

packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/layout_explorer_widget.dart

@@ -89,8 +89,6 @@ abstract class LayoutExplorerWidgetState<W extends LayoutExplorerWidget,
   /// Whether this layout explorer can work with this kind of node.
   bool shouldDisplay(RemoteDiagnosticsNode node);
 
-  Size get size => properties!.size;
-
   List<LayoutProperties> get children => properties!.displayChildren;
 
   LayoutProperties? highlighted;

packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/theme.dart

@@ -46,8 +46,6 @@ const smallTextScaleFactor = 0.8;
 /// Height for limiting asset image (selected one in the drop down).
 double get axisAlignmentAssetImageHeight => scaleByFontFactor(24.0);
 
-/// Width for limiting asset image (when drop down menu is open for the vertical).
-double get axisAlignmentAssetImageWidth => scaleByFontFactor(96.0);
 double get dropdownMaxSize => scaleByFontFactor(220.0);
 
 double get minHeightToAllowTruncating => scaleByFontFactor(375.0);
@@ -56,11 +54,6 @@ double get minWidthToAllowTruncating => scaleByFontFactor(375.0);
 // Story of Layout colors
 const mainAxisLightColor = Color(0xff2c5daa);
 const mainAxisDarkColor = Color(0xff2c5daa);
-const rowColor = Color(0xff2c5daa);
-const columnColor = Color(0xff77974d);
-const regularWidgetColor = Color(0xff88b1de);
-
-const selectedWidgetColor = Color(0xff36c6f4);
 
 const textColor = Color(0xff55767f);
 const emphasizedTextColor = Color(0xff009aca);
@@ -108,9 +101,6 @@ extension LayoutExplorerColorScheme on ColorScheme {
   Color get backgroundColorSelected =>
       isLight ? backgroundColorSelectedLight : backgroundColorSelectedDark;
 
-  Color get backgroundColor =>
-      isLight ? backgroundColorLight : backgroundColorDark;
-
   Color get unconstrainedColor =>
       isLight ? unconstrainedLightColor : unconstrainedDarkColor;
 }
@@ -124,8 +114,6 @@ const unconstrainedLightColor = Color(0xfff5846b);
 const widthIndicatorColor = textColor;
 const heightIndicatorColor = textColor;
 
-extension LayoutThemeDataExtension on ThemeData {}
-
 const negativeSpaceDarkAssetName =
     'assets/img/layout_explorer/negative_space_dark.png';
 const negativeSpaceLightAssetName =

packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/utils.dart

@@ -52,18 +52,6 @@ class BorderLayout extends StatelessWidget {
   final double? topHeight;
   final double? bottomHeight;
 
-  CrossAxisAlignment get crossAxisAlignment {
-    if (left != null && right != null) {
-      return CrossAxisAlignment.center;
-    } else if (left == null && right != null) {
-      return CrossAxisAlignment.start;
-    } else if (left != null && right == null) {
-      return CrossAxisAlignment.end;
-    } else {
-      return CrossAxisAlignment.start;
-    }
-  }
-
   @override
   Widget build(BuildContext context) {
     return Stack(

packages/devtools_app/lib/src/screens/memory/memory_screen.dart

@@ -96,10 +96,7 @@ class MemoryBodyState extends State<MemoryBody>
     return Column(
       key: MemoryChartPane.hoverKey,
       children: [
-        MemoryControlPane(
-          chartController: _chartController,
-          controller: controller,
-        ),
+        MemoryControlPane(controller: controller),
         const SizedBox(height: denseRowSpacing),
         MemoryChartPane(
           chartController: _chartController,

packages/devtools_app/lib/src/screens/memory/panes/chart/chart_pane_controller.dart

@@ -23,8 +23,6 @@ class MemoryChartPaneController {
 
   final _legendVisibleNotifier = ValueNotifier<bool>(true);
 
-  bool get isLegendVisible => _legendVisibleNotifier.value;
-
   bool toggleLegendVisibility() =>
       _legendVisibleNotifier.value = !_legendVisibleNotifier.value;
 

packages/devtools_app/lib/src/screens/memory/panes/chart/interval_dropdown.dart

@@ -12,8 +12,6 @@ import '../../memory_controller.dart';
 import 'chart_pane_controller.dart';
 import 'primitives.dart';
 
-const verboseDropDownMinimumWidth = 950;
-
 class IntervalDropdown extends StatefulWidget {
   const IntervalDropdown({Key? key, required this.chartController})
       : super(key: key);

packages/devtools_app/lib/src/screens/memory/panes/chart/legend.dart

@@ -56,7 +56,6 @@ class MemoryChartLegend extends StatelessWidget {
         LegendRow(
           entry1: leftEntry,
           entry2: rightEntry,
-          chartController: chartController,
         ),
       );
     }
@@ -73,7 +72,6 @@ class MemoryChartLegend extends StatelessWidget {
       legendRows.add(
         LegendRow(
           entry1: entry,
-          chartController: chartController,
         ),
       );
     }
@@ -91,7 +89,6 @@ class MemoryChartLegend extends StatelessWidget {
         legendRows.add(
           LegendRow(
             entry1: entry,
-            chartController: chartController,
           ),
         );
       }
@@ -119,12 +116,10 @@ class MemoryChartLegend extends StatelessWidget {
 class LegendRow extends StatelessWidget {
   const LegendRow({
     Key? key,
-    required this.chartController,
     required this.entry1,
     this.entry2,
   }) : super(key: key);
 
-  final MemoryChartPaneController chartController;
   final MapEntry<String, Map<String, Object?>> entry1;
   final MapEntry<String, Map<String, Object?>>? entry2;
 

packages/devtools_app/lib/src/screens/memory/panes/control/control_pane.dart

@@ -5,18 +5,15 @@
 import 'package:flutter/material.dart';
 
 import '../../memory_controller.dart';
-import '../chart/chart_pane_controller.dart';
 import 'primary_controls.dart';
 import 'secondary_controls.dart';
 
 class MemoryControlPane extends StatelessWidget {
   const MemoryControlPane({
     Key? key,
-    required this.chartController,
     required this.controller,
   }) : super(key: key);
 
-  final MemoryChartPaneController chartController;
   final MemoryController controller;
 
   @override
@@ -26,10 +23,7 @@ class MemoryControlPane extends StatelessWidget {
       children: [
         const PrimaryControls(),
         const Spacer(),
-        SecondaryControls(
-          chartController: chartController,
-          controller: controller,
-        ),
+        SecondaryControls(controller: controller),
       ],
     );
   }

packages/devtools_app/lib/src/screens/memory/panes/control/primitives.dart

@@ -12,18 +12,15 @@ import '../../../../shared/common_widgets.dart';
 import '../../../../shared/theme.dart';
 import '../../memory_controller.dart';
 import '../../shared/primitives/simple_elements.dart';
-import '../chart/chart_pane_controller.dart';
 import 'settings_dialog.dart';
 
 /// Controls related to the entire memory screen.
 class SecondaryControls extends StatelessWidget {
   const SecondaryControls({
     Key? key,
-    required this.chartController,
     required this.controller,
   }) : super(key: key);
 
-  final MemoryChartPaneController chartController;
   final MemoryController controller;
 
   @override
@@ -55,7 +52,7 @@ class SecondaryControls extends StatelessWidget {
     unawaited(
       showDialog(
         context: context,
-        builder: (context) => MemorySettingsDialog(controller),
+        builder: (context) => const MemorySettingsDialog(),
       ),
     );
   }