Skip to content

Re-land program explorer #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kenzieschmoll opened this issue Oct 1, 2021 · 1 comment
Closed

Re-land program explorer #3418

kenzieschmoll opened this issue Oct 1, 2021 · 1 comment
Assignees
@bkonyi
Milestone
M34

Comments

@kenzieschmoll
Copy link
Member

Revert #3417 (which is the revert of the ProgramExplorer code). #3227 caused a regression in startup time due to the number of new vm service calls to getObject. Attached are two log files: one of the vm_service calls triggered by connecting to a DevTools app before the program explorer code was landed, and one after (see the 11,000+ calls to getObject in the latter).

pixel-3-vm-service-calls-before.txt
pixel-3-vm-service-calls-after.txt
@kenzieschmoll kenzieschmoll mentioned this issue Oct 4, 2021
Closed
@kenzieschmoll kenzieschmoll added this to the M34 milestone Oct 7, 2021
@bkonyi
Copy link
Contributor

bkonyi commented Oct 20, 2021

Fixed in #3448

@bkonyi bkonyi closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
None yet
Projects
None yet
Milestone
M34
Development

No branches or pull requests
2 participants
@bkonyi @kenzieschmoll