[fasta] Disable upwards new/const completion

Change-Id: If2c14bf402bbcbacbf4cf2da351eb7234e1e0944
Reviewed-on: https://dart-review.googlesource.com/49900
Commit-Queue: Dmitry Stefantsov <[email protected]>
Reviewed-by: Kevin Millikin <[email protected]>

Author: Dmitry Stefantsov

pkg/front_end/lib/src/fasta/constant_context.dart

@@ -23,19 +23,4 @@ enum ConstantContext {
   /// This means that `Object()` and `[]` are equivalent to `const Object()` and
   /// `const []` respectively. `new Object()` is a compile-time error.
   inferred,
-
-  /// In a context that allows only constant values, but requires them to be
-  /// defined as `const` explicitly.  For example, in default values of optional
-  /// and named parameters.
-  ///
-  /// The following code should emit a compile-time error:
-  ///
-  ///     class Bar { const Bar(); }
-  ///     class Foo { void foo({Bar bar: Bar()}) {} }
-  ///
-  /// The following code should compile without errors:
-  ///
-  ///     class Bar { const Bar(); }
-  ///     class Foo { void foo({Bar bar: const Bar()}) {} }
-  needsExplicitConst,
 }

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart

@@ -3761,18 +3761,6 @@ const MessageCode messageNativeClauseShouldBeAnnotation = const MessageCode(
     tip:
         r"""Try removing this native clause and adding @native() or @native('native-name') before the declaration.""");
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeNeedExplicitConst = messageNeedExplicitConst;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageNeedExplicitConst = const MessageCode(
-    "NeedExplicitConst",
-    analyzerCode: "NON_CONSTANT_DEFAULT_VALUE",
-    dart2jsCode: "*fatal*",
-    severity: Severity.error,
-    message: r"""An explicit 'const' keyword is expected here.""",
-    tip: r"""Put the 'const' keyword at this position.""");
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<
     Message Function(Token token)> templateNoFormals = const Template<

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -76,8 +76,6 @@ import 'redirecting_factory_body.dart'
 
 import '../names.dart';
 
-import 'constness_evaluator.dart' show evaluateConstness;
-
 import 'fasta_accessors.dart';
 
 import 'kernel_api.dart';
@@ -185,12 +183,6 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
   /// and where that was.
   Map<String, int> initializedFields;
 
-  /// Constructor invocations (either generative or factory) with not specified
-  /// `new` or `const` keywords.  The constness for these should be inferred
-  /// based on the subexpressions.
-  List<Expression> constructorInvocationsWithImplicitConstness =
-      new List<Expression>();
-
   BodyBuilder(
       KernelLibraryBuilder library,
       this.member,
@@ -497,8 +489,6 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
         }
       }
     }
-
-    inferConstness();
   }
 
   @override
@@ -696,24 +686,6 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
       unhandled("${builder.runtimeType}", "finishFunction", builder.charOffset,
           builder.fileUri);
     }
-
-    inferConstness();
-  }
-
-  // Infers constness of the constructor invocations collected so far in
-  // [constructorInvocationsWithImplicitConstness], then clears out the list.
-  void inferConstness() {
-    for (Expression invocation in constructorInvocationsWithImplicitConstness) {
-      if (invocation is ConstructorInvocation) {
-        invocation.isConst = evaluateConstness(invocation, coreTypes, uri);
-      } else if (invocation is StaticInvocation) {
-        invocation.isConst = evaluateConstness(invocation, coreTypes, uri);
-      } else {
-        unhandled("${invocation.runtimeType}", "inferConstness",
-            invocation.fileOffset, invocation.location.file);
-      }
-    }
-    constructorInvocationsWithImplicitConstness.clear();
   }
 
   @override
@@ -2170,7 +2142,7 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
   @override
   void beginFormalParameterDefaultValueExpression() {
     super.push(constantContext);
-    constantContext = ConstantContext.needsExplicitConst;
+    constantContext = ConstantContext.none;
   }
 
   @override
@@ -2497,31 +2469,17 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
           argMessage: argMessage);
     }
     if (target is Constructor) {
-      if (constantContext == ConstantContext.needsExplicitConst &&
-          constness == Constness.implicit) {
-        return buildCompileTimeError(
-            fasta.messageNeedExplicitConst, charOffset, noLength);
-      }
       isConst =
           isConst || constantContext != ConstantContext.none && target.isConst;
       if ((isConst || constantContext == ConstantContext.inferred) &&
           !target.isConst) {
         return deprecated_buildCompileTimeError(
             "Not a const constructor.", charOffset);
       }
-      ShadowConstructorInvocation invocation = new ShadowConstructorInvocation(
-          target,
-          targetTypeArguments,
-          initialTarget,
-          forest.castArguments(arguments),
+      return new ShadowConstructorInvocation(target, targetTypeArguments,
+          initialTarget, forest.castArguments(arguments),
           isConst: isConst)
         ..fileOffset = charOffset;
-      if (constness == Constness.implicit &&
-          target.isConst &&
-          constantContext != ConstantContext.inferred) {
-        constructorInvocationsWithImplicitConstness.add(invocation);
-      }
-      return invocation;
     } else {
       Procedure procedure = target;
       if (procedure.isFactory) {
@@ -2532,22 +2490,10 @@ class BodyBuilder<Arguments> extends ScopeListener<JumpTarget>
           return deprecated_buildCompileTimeError(
               "Not a const factory.", charOffset);
         }
-        if (constantContext == ConstantContext.needsExplicitConst &&
-            constness == Constness.implicit) {
-          return buildCompileTimeError(
-              fasta.messageNeedExplicitConst, charOffset, noLength);
-        }
-        ShadowFactoryConstructorInvocation invocation =
-            new ShadowFactoryConstructorInvocation(target, targetTypeArguments,
-                initialTarget, forest.castArguments(arguments),
-                isConst: isConst)
-              ..fileOffset = charOffset;
-        if (constness == Constness.implicit &&
-            procedure.isConst &&
-            constantContext != ConstantContext.inferred) {
-          constructorInvocationsWithImplicitConstness.add(invocation);
-        }
-        return invocation;
+        return new ShadowFactoryConstructorInvocation(target,
+            targetTypeArguments, initialTarget, forest.castArguments(arguments),
+            isConst: isConst)
+          ..fileOffset = charOffset;
       } else {
         return new ShadowStaticInvocation(
             target, forest.castArguments(arguments),

pkg/front_end/messages.yaml

@@ -2061,17 +2061,3 @@ ImplicitCallOfNonMethod:
   template: "Can't invoke the type '#type' because its declaration of `.call` is not a method."
   tip: "Change .call to a method or explicitly invoke .call."
   severity: ERROR
-
-NeedExplicitConst:
-  template: "An explicit 'const' keyword is expected here."
-  tip: "Put the 'const' keyword at this position."
-  severity: ERROR
-  analyzerCode: NON_CONSTANT_DEFAULT_VALUE # TODO(dmitryas): Ask the analyzer team if the code is correct.
-  dart2jsCode: "*fatal*"
-  script: >
-    class Foo {
-      const Foo();
-    }
-    class Bar {
-      const Bar([Foo foo = Foo()]);
-    }

pkg/front_end/testcases/implicit_const_with_static_fields.dart.direct.expect

@@ -10,6 +10,6 @@ class C extends core::Object {
 }
 static const field dynamic constTopLevelField = 42;
 static method main() → dynamic {
-  const self::C::•(self::C::constField);
-  const self::C::•(self::constTopLevelField);
+  new self::C::•(self::C::constField);
+  new self::C::•(self::constTopLevelField);
 }

pkg/front_end/testcases/implicit_const_with_static_fields.dart.direct.transformed.expect

@@ -10,6 +10,6 @@ class C extends core::Object {
 }
 static const field dynamic constTopLevelField = 42;
 static method main() → dynamic {
-  const self::C::•(self::C::constField);
-  const self::C::•(self::constTopLevelField);
+  new self::C::•(self::C::constField);
+  new self::C::•(self::constTopLevelField);
 }

pkg/front_end/testcases/implicit_const_with_static_fields.dart.strong.expect

@@ -10,6 +10,6 @@ class C extends core::Object {
 }
 static const field core::int constTopLevelField = 42;
 static method main() → dynamic {
-  const self::C::•(self::C::constField);
-  const self::C::•(self::constTopLevelField);
+  new self::C::•(self::C::constField);
+  new self::C::•(self::constTopLevelField);
 }

pkg/front_end/testcases/implicit_const_with_static_fields.dart.strong.transformed.expect

@@ -10,6 +10,6 @@ class C extends core::Object {
 }
 static const field core::int constTopLevelField = 42;
 static method main() → dynamic {
-  const self::C::•(self::C::constField);
-  const self::C::•(self::constTopLevelField);
+  new self::C::•(self::C::constField);
+  new self::C::•(self::constTopLevelField);
 }

pkg/front_end/testcases/magic_const.dart.direct.expect

@@ -12,20 +12,14 @@ class NotConstant extends core::Object {
     : super core::Object::•()
     ;
 }
-static method foo({dynamic a = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:9: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-        ^", dynamic b = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:24: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-                       ^", dynamic c = <dynamic>[]}) → dynamic {}
+static method foo({dynamic a = new self::Constant::•(), dynamic b = new self::Constant::•(), dynamic c = <dynamic>[]}) → dynamic {}
 static method test() → dynamic {
   invalid-expression "pkg/front_end/testcases/magic_const.dart:18:9: Error: Not a const constructor.
   const NotConstant();
         ^";
-  const self::Constant::•();
+  new self::Constant::•();
   const dynamic x = const self::Constant::•();
-  const core::bool::fromEnvironment("fisk");
+  core::bool::fromEnvironment("fisk");
   const dynamic b = const core::bool::fromEnvironment("fisk");
 }
 static method main() → dynamic {}

pkg/front_end/testcases/magic_const.dart.direct.transformed.expect

@@ -12,20 +12,14 @@ class NotConstant extends core::Object {
     : super core::Object::•()
     ;
 }
-static method foo({dynamic a = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:9: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-        ^", dynamic b = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:24: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-                       ^", dynamic c = <dynamic>[]}) → dynamic {}
+static method foo({dynamic a = new self::Constant::•(), dynamic b = new self::Constant::•(), dynamic c = <dynamic>[]}) → dynamic {}
 static method test() → dynamic {
   invalid-expression "pkg/front_end/testcases/magic_const.dart:18:9: Error: Not a const constructor.
   const NotConstant();
         ^";
-  const self::Constant::•();
+  new self::Constant::•();
   const dynamic x = const self::Constant::•();
-  const core::bool::fromEnvironment("fisk");
+  core::bool::fromEnvironment("fisk");
   const dynamic b = const core::bool::fromEnvironment("fisk");
 }
 static method main() → dynamic {}

pkg/front_end/testcases/magic_const.dart.strong.expect

@@ -12,20 +12,14 @@ class NotConstant extends core::Object {
     : super core::Object::•()
     ;
 }
-static method foo({dynamic a = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:9: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-        ^", dynamic b = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:24: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-                       ^", dynamic c = <dynamic>[]}) → dynamic {}
+static method foo({dynamic a = new self::Constant::•(), dynamic b = new self::Constant::•(), dynamic c = <dynamic>[]}) → dynamic {}
 static method test() → dynamic {
   invalid-expression "pkg/front_end/testcases/magic_const.dart:18:9: Error: Not a const constructor.
   const NotConstant();
         ^";
-  const self::Constant::•();
+  new self::Constant::•();
   const self::Constant x = const self::Constant::•();
-  const core::bool::fromEnvironment("fisk");
+  core::bool::fromEnvironment("fisk");
   const core::bool b = const core::bool::fromEnvironment("fisk");
 }
 static method main() → dynamic {}

pkg/front_end/testcases/magic_const.dart.strong.transformed.expect

@@ -12,20 +12,14 @@ class NotConstant extends core::Object {
     : super core::Object::•()
     ;
 }
-static method foo({dynamic a = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:9: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-        ^", dynamic b = invalid-expression "pkg/front_end/testcases/magic_const.dart:15:24: Error: An explicit 'const' keyword is expected here.
-Put the 'const' keyword at this position.
-foo({a: Constant(), b: Constant(), c: []}) {}
-                       ^", dynamic c = <dynamic>[]}) → dynamic {}
+static method foo({dynamic a = new self::Constant::•(), dynamic b = new self::Constant::•(), dynamic c = <dynamic>[]}) → dynamic {}
 static method test() → dynamic {
   invalid-expression "pkg/front_end/testcases/magic_const.dart:18:9: Error: Not a const constructor.
   const NotConstant();
         ^";
-  const self::Constant::•();
+  new self::Constant::•();
   const self::Constant x = const self::Constant::•();
-  const core::bool::fromEnvironment("fisk");
+  core::bool::fromEnvironment("fisk");
   const core::bool b = const core::bool::fromEnvironment("fisk");
 }
 static method main() → dynamic {}

pkg/front_end/testcases/nested_implicit_const_with_env_var.dart.direct.expect

@@ -19,7 +19,7 @@ class C extends core::Object {
     : super core::Object::•()
     ;
   method fun() → dynamic {
-    const self::B::•(const self::A::•(self::foo));
+    new self::B::•(new self::A::•(self::foo));
   }
 }
 static const field core::int foo = const core::int::fromEnvironment("fisk");

pkg/front_end/testcases/nested_implicit_const_with_env_var.dart.direct.transformed.expect

@@ -19,7 +19,7 @@ class C extends core::Object {
     : super core::Object::•()
     ;
   method fun() → dynamic {
-    const self::B::•(const self::A::•(self::foo));
+    new self::B::•(new self::A::•(self::foo));
   }
 }
 static const field core::int foo = const core::int::fromEnvironment("fisk");

pkg/front_end/testcases/nested_implicit_const_with_env_var.dart.strong.expect

@@ -19,7 +19,7 @@ class C extends core::Object {
     : super core::Object::•()
     ;
   method fun() → dynamic {
-    const self::B::•(const self::A::•(self::foo));
+    new self::B::•(new self::A::•(self::foo));
   }
 }
 static const field core::int foo = const core::int::fromEnvironment("fisk");

pkg/front_end/testcases/nested_implicit_const_with_env_var.dart.strong.transformed.expect

@@ -19,7 +19,7 @@ class C extends core::Object {
     : super core::Object::•()
     ;
   method fun() → dynamic {
-    const self::B::•(const self::A::•(self::foo));
+    new self::B::•(new self::A::•(self::foo));
   }
 }
 static const field core::int foo = const core::int::fromEnvironment("fisk");

pkg/front_end/testcases/new_const_insertion/simple.dart.direct.expect

@@ -10,8 +10,8 @@ class A extends core::Object {
 }
 static method main() → dynamic {
   core::int foo = 42;
-  const self::A::•(5);
-  const self::A::•(5.+(5));
+  new self::A::•(5);
+  new self::A::•(5.+(5));
   new self::A::•(foo);
   new self::A::•(5.+(foo));
 }

pkg/front_end/testcases/new_const_insertion/simple.dart.direct.transformed.expect

@@ -10,8 +10,8 @@ class A extends core::Object {
 }
 static method main() → dynamic {
   core::int foo = 42;
-  const self::A::•(5);
-  const self::A::•(5.+(5));
+  new self::A::•(5);
+  new self::A::•(5.+(5));
   new self::A::•(foo);
   new self::A::•(5.+(foo));
 }

pkg/front_end/testcases/new_const_insertion/simple.dart.strong.expect

@@ -10,8 +10,8 @@ class A extends core::Object {
 }
 static method main() → dynamic {
   core::int foo = 42;
-  const self::A::•(5);
-  const self::A::•(5.{core::num::+}(5));
+  new self::A::•(5);
+  new self::A::•(5.{core::num::+}(5));
   new self::A::•(foo);
   new self::A::•(5.{core::num::+}(foo));
 }

pkg/front_end/testcases/new_const_insertion/simple.dart.strong.transformed.expect

@@ -10,8 +10,8 @@ class A extends core::Object {
 }
 static method main() → dynamic {
   core::int foo = 42;
-  const self::A::•(5);
-  const self::A::•(5.{core::num::+}(5));
+  new self::A::•(5);
+  new self::A::•(5.{core::num::+}(5));
   new self::A::•(foo);
   new self::A::•(5.{core::num::+}(foo));
 }