Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 1b8968c

Browse files
committed
Merge pull request #20 from eseidelGoogle/system_bar
Don't layout behind the system bar if we can't make it transparent
2 parents 512f7cb + 8720ecf commit 1b8968c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sky/shell/android/org/domokit/sky/shell/SkyActivity.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,11 @@ protected void onCreate(Bundle savedInstanceState) {
3737
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
3838
getWindow().addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS);
3939
getWindow().setStatusBarColor(0x40000000);
40-
// TODO(abarth): We should get this value from the Android framework somehow.
41-
edgeDims.top = 25.0;
4240
}
41+
// TODO(abarth): We should get this value from the Android framework somehow.
42+
edgeDims.top = 25.0;
43+
// TODO(abarth): Unclear if we want to use fullscreen if we don't have
44+
// a transparent system bar.
4345
getWindow().getDecorView().setSystemUiVisibility(
4446
View.SYSTEM_UI_FLAG_LAYOUT_STABLE
4547
| View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);

0 commit comments

Comments
 (0)